-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refuce f16 #261
Merged
Merged
Refuce f16 #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
CongMa13
commented
Aug 7, 2024
•
edited
Loading
edited
- Support f16/f16, bf16/bf16, f16/f32, bf16/f32 reduction
- Support independent C and D
- Add another CK instance with InSrcVectorDim==1 which supports far right dim
- Support reducing a tensor to a scalar
- Support permutation of output of reduction
- Fix bugs
Add F16 anf bf16 instances since CK supports them now.
CongMa13
commented
Aug 8, 2024
CongMa13
commented
Aug 8, 2024
CongMa13
commented
Aug 8, 2024
Test cases that beta != 0 cannot pass for a CK bug. Will add the test cases back when the CK fix is merged into amd_master
CongMa13
commented
Aug 12, 2024
CongMa13
commented
Aug 12, 2024
Tensor C and D can point to the same tensor or two distinct tensors
CongMa13
commented
Aug 13, 2024
CongMa13
commented
Aug 13, 2024
CongMa13
commented
Aug 13, 2024
CongMa13
commented
Aug 13, 2024
CongMa13
commented
Aug 13, 2024
CongMa13
requested review from
cgmillette,
bragadeesh,
mkarunan,
dlangbe and
afanfa
as code owners
August 13, 2024 14:40
CongMa13
commented
Aug 13, 2024
CongMa13
commented
Aug 14, 2024
CongMa13
commented
Aug 14, 2024
cgmillette
reviewed
Aug 16, 2024
cgmillette
reviewed
Aug 16, 2024
cgmillette
reviewed
Aug 16, 2024
cgmillette
reviewed
Aug 16, 2024
cgmillette
reviewed
Aug 16, 2024
cgmillette
reviewed
Aug 16, 2024
library/src/reduction/reduction_solution_5_4_f16_f32_instance.cpp
Outdated
Show resolved
Hide resolved
cgmillette
reviewed
Aug 16, 2024
cgmillette
reviewed
Aug 16, 2024
cgmillette
approved these changes
Aug 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending CI
CongMa13
added a commit
to CongMa13/hipTensor
that referenced
this pull request
Aug 20, 2024
- Support f16/f16, bf16/bf16, f16/f32, bf16/f32 reduction - Use f32 as compute type for f16/f16, bf16/bf16 - Support independent C and D - Add another CK instance with InSrcVectorDim==1 which supports far right dim - Support reducing a tensor to a scalar - Support permutation of output of reduction - Rename label [Reduced Dims] to [Output Dims] in reduction test config file - Commnet out all test cases that beta != 0. Will add the test cases back when the CK fix is merged into amd_master - Fix bugs
CongMa13
added a commit
that referenced
this pull request
Sep 24, 2024
- Support f16/f16, bf16/bf16, f16/f32, bf16/f32 reduction - Use f32 as compute type for f16/f16, bf16/bf16 - Support independent C and D - Add another CK instance with InSrcVectorDim==1 which supports far right dim - Support reducing a tensor to a scalar - Support permutation of output of reduction - Rename label [Reduced Dims] to [Output Dims] in reduction test config file - Commnet out all test cases that beta != 0. Will add the test cases back when the CK fix is merged into amd_master - Fix bugs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.