Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Grafana Plugin #151

Merged
merged 3 commits into from
Aug 1, 2023
Merged

Update Grafana Plugin #151

merged 3 commits into from
Aug 1, 2023

Conversation

JoseSantosAMD
Copy link
Contributor

@JoseSantosAMD JoseSantosAMD commented Jul 17, 2023

Addresses issue #141

Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com>
Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com>
Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com>
@coleramos425
Copy link
Collaborator

@JoseSantosAMD for the failing "formatting" test you'll need to comply with Python formatting reqs, i.e.

$ python 3 -m pip install black
$ cd omniperf/ && black --diff --check . # See which files require reformatting
$ black . # Reformat files

The Ubuntu/RHEL tests indicate your code's failing an analyze cmd case

@coleramos425
Copy link
Collaborator

coleramos425 commented Aug 1, 2023

Facing Docker build issue when mounting persistent volumes. Steps to recreate:

$ sudo mkdir -p /usr/local/persist && cd /usr/local/persist/
$ sudo mkdir -p grafana-storage mongodb
$ sudo docker volume create --driver local --opt type=none --opt device=/usr/local/persist/grafana-storage --opt o=bind grafana-storage
$ sudo docker volume create --driver local --opt type=none --opt device=/usr/local/persist/mongodb --opt o=bind grafana-mongo-db

image

UPDATE
The above issue was produced on a shared server. When attempting to reproduce issue on personal workstation the error went away.

Now I encounter a "Bad Gateway" Error in Memory chart panel after importing dashboard json from GitHub. Please test to see if you can reproduce @JoseSantosAMD
image

UPDATE
Isolated this issue to a hipBone workload. Testing issue further in a separate ticket -- seems like it is not isolated to this PR.

@coleramos425 coleramos425 changed the base branch from main to dev August 1, 2023 18:46
@coleramos425 coleramos425 merged commit 83a8577 into ROCm:dev Aug 1, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants