Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only load ArchConfigs for detected SoC #152

Closed
wants to merge 3 commits into from

Conversation

JoseSantosAMD
Copy link
Contributor

@JoseSantosAMD JoseSantosAMD commented Jul 19, 2023

Addresses issue #144

Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com>
Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com>
Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com>
@coleramos425 coleramos425 changed the title Enhancement 144 Only load ArchConfigs for detected SoC Jul 20, 2023
@feizheng10
Copy link
Contributor

@coleramos425 coleramos425 changed the base branch from main to dev August 1, 2023 18:48
@coleramos425
Copy link
Collaborator

Rejecting PR. Doesn't take into account multiple paths which could have different SoCs (i.e. intra SoC comparison) -- this case breaks your logic. For example,

omniperf analyze -p workloads/test_1/mi200 -p workloads/test_2/mi100

I'll take this PR and submit a re-worked version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants