Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kernel name demangle #157

Merged
merged 13 commits into from
Aug 15, 2023
Merged

Conversation

JoseSantosAMD
Copy link
Contributor

@JoseSantosAMD JoseSantosAMD commented Aug 2, 2023

Closes #142

Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com>
Show typed text in in dash-dropdown input box

Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com>
Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com>
@coleramos425
Copy link
Collaborator

In order for demangler to work in CLI analysis mode we'll need to reference kernel_name_shortner() from inside profile mode. Thus overwriting mangled KernelNames in CSVs (as part of profiling pipeline).

It seems most logical to move the --kernelVerbose flag into profile mode and give the user the option to toggle the demangling from here

@coleramos425 coleramos425 changed the base branch from main to dev August 2, 2023 20:45
JoseSantosAMD and others added 5 commits August 8, 2023 12:06
shortening now in profile

Signed-off-by: JoseSantosAMD <josantos@amd.com>
Signed-off-by: josantos <josantos@amd.com>
-  Added kernelVerbose flag in profile_group
-  Added KernelVerbose flag in analyze_group
-  Analyze replaces csv with shortened/demangled name
-  csv_converter uses llvm-cxxfilt

Signed-off-by: josantos <josantos@amd.com>
Signed-off-by: josantos <josantos@amd.com>
Signed-off-by: josantos <josantos@amd.com>
Signed-off-by: josantos <josantos@amd.com>
Signed-off-by: josantos <josantos@amd.com>
@coleramos425
Copy link
Collaborator

@JoseSantosAMD isn't there a new package required for llvm-cxxfilt? If it's a Python package we need to make sure it's included in the requirements.txt, otherwise we'll have to make sure it's listed in our docs.

@JoseSantosAMD
Copy link
Contributor Author

No, it uses /opt/rocm/llvm/bin/llvm-cxxfilt

Signed-off-by: coleramos425 <colramos@amd.com>
Signed-off-by: coleramos425 <colramos@amd.com>
@coleramos425 coleramos425 merged commit b79b4d3 into ROCm:dev Aug 15, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants