Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instr mix min max avg #158

Merged
merged 35 commits into from
Aug 15, 2023
Merged
Show file tree
Hide file tree
Changes from 34 commits
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
cc19506
Adding min/max/avg breakdown across dispatches for instruction mix pa…
JoseSantosAMD Aug 7, 2023
c16656e
Fix VGPR issue (#139)
coleramos425 Jun 9, 2023
599bc01
Omniperf rocomni changes
coleramos425 Jun 9, 2023
48f037e
Comply to Python formatting
coleramos425 Jun 9, 2023
0b135be
Add subsection title to System Speed-of-Light
coleramos425 Jun 21, 2023
5e52983
Extend filtering into timestamps.csv (#80)
coleramos425 Jun 26, 2023
8ae8395
Comply to Python formatting
coleramos425 Jun 26, 2023
607d9f7
Add options to enable latexpdf builds
Jun 7, 2023
a6a0fc4
apply formatting
Jun 7, 2023
931a333
updating path for rocm repo to supported rhel8 release (8.8)
koomie Jun 30, 2023
dcd2595
Fixed Units inconsistencies
JoseSantosAMD Jul 10, 2023
02c6473
Update 1800_L2_cache_per_channel.yaml
coleramos425 Jul 11, 2023
3daad29
Update 1800_L2_cache_per_channel.yaml
coleramos425 Jul 11, 2023
33ad9ff
Rearranging build_df func to optimize ArchConfig for rocomni plugin
coleramos425 Jul 11, 2023
2c2b384
Abstract perfmon coalesing for useage in rocomni plugin
coleramos425 Jul 11, 2023
35daf8c
Comply to Python formatting
coleramos425 Jul 11, 2023
626fc7f
Filter additional ops in gen_counter_list fucn
coleramos425 Jul 17, 2023
e6ca8e0
Enable join_prof() merge util to be called from outside Omniperf
coleramos425 Jul 17, 2023
424dd6a
Add figure styling to YML configs
coleramos425 Jul 18, 2023
a61d509
New simple_charts utility
coleramos425 Jul 18, 2023
08f4684
Migrate to @grafana/create-plugin
JoseSantosAMD Jul 17, 2023
c209583
Adding config files
JoseSantosAMD Jul 17, 2023
7ed6c62
Adding config files
JoseSantosAMD Jul 17, 2023
db9cc25
Fix incorrect ordering of args in perfagg func
coleramos425 Aug 2, 2023
b1a7a26
Only load required archs into ArchConfig datastruct (#144)
coleramos425 Aug 2, 2023
428d07a
fix max BF16 flop rate on CDNA2
Jul 28, 2023
ef8ef22
Fix syntax error in yaml
JoseSantosAMD Aug 7, 2023
d6fb018
Fixing yaml syntax errors
JoseSantosAMD Aug 7, 2023
11b5f65
Fix yaml syntax errors
JoseSantosAMD Aug 8, 2023
bfbd5bb
Adding min/max/avg breakdown across dispatches for instruction mix pa…
JoseSantosAMD Aug 7, 2023
57a75f9
Merge branch 'dev' into instr_mix_min_max_avg
JoseSantosAMD Aug 10, 2023
5dac904
Update 1000_compute-unit-instruction-mix.yaml
JoseSantosAMD Aug 10, 2023
b82f033
Added min/max/avg to VALU Arithmetic Instr Mix
JoseSantosAMD Aug 11, 2023
e25d61d
add hidden min/max to instr mix panels
JoseSantosAMD Aug 14, 2023
6d39955
add simple_bar styling
JoseSantosAMD Aug 15, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
689 changes: 351 additions & 338 deletions dashboards/Omniperf_v1.0.8_pub.json

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -13,43 +13,61 @@ Panel Config:
title: Instruction Mix
header:
metric: Metric
count: Count
avg: Avg
min: Min
max: Max
unit: Unit
tips: Tips
style:
type: simple_bar
label_txt: (# of instr + $normUnit)
metric:
VALU - Vector:
count: None # No HW module
avg: None # No HW module
min: None # No HW module
max: None # No HW module
unit: (instr + $normUnit)
tips:
VMEM:
count: None # No HW module
avg: None # No HW module
min: None # No HW module
max: None # No HW module
unit: (instr + $normUnit)
tips:
LDS:
count: AVG((SQ_INSTS_LDS / $denom))
avg: AVG((SQ_INSTS_LDS / $denom))
min: MIN((SQ_INSTS_LDS / $denom))
max: MAX((SQ_INSTS_LDS / $denom))
unit: (instr + $normUnit)
tips:
VALU - MFMA:
count: None # No HW module
avg: None # No HW module
min: None # No HW module
max: None # No HW module
unit: (instr + $normUnit)
tips:
SALU:
count: AVG((SQ_INSTS_SALU / $denom))
avg: AVG((SQ_INSTS_SALU / $denom))
min: MIN((SQ_INSTS_SALU / $denom))
max: MAX((SQ_INSTS_SALU / $denom))
unit: (instr + $normUnit)
tips:
SMEM:
count: AVG((SQ_INSTS_SMEM / $denom))
avg: AVG((SQ_INSTS_SMEM / $denom))
min: MIN((SQ_INSTS_SMEM / $denom))
max: MAX((SQ_INSTS_SMEM / $denom))
unit: (instr + $normUnit)
tips:
Branch:
count: AVG((SQ_INSTS_BRANCH / $denom))
avg: AVG((SQ_INSTS_BRANCH / $denom))
min: MIN((SQ_INSTS_BRANCH / $denom))
max: MAX((SQ_INSTS_BRANCH / $denom))
unit: (instr + $normUnit)
tips:
GDS:
count: AVG((SQ_INSTS_GDS / $denom))
avg: AVG((SQ_INSTS_GDS / $denom))
min: MIN((SQ_INSTS_GDS / $denom))
max: MAX((SQ_INSTS_GDS / $denom))
unit: (instr + $normUnit)
tips:

Expand All @@ -58,71 +76,103 @@ Panel Config:
title: VALU Arithmetic Instr Mix
header:
metric: Metric
count: Count
avg: Avg
min: Min
max: Max
unit: Unit
tips: Tips
style:
type: simple_bar
label_txt: (# of instr + $normUnit)
metric:
INT-32:
count: None # No perf counter
avg: None # No HW module
min: None # No HW module
max: None # No HW module
unit: (instr + $normUnit)
tips:
INT-64:
count: None # No perf counter
avg: None # No HW module
min: None # No HW module
max: None # No HW module
unit: (instr + $normUnit)
tips:
F16-ADD:
count: None # No perf counter
avg: None # No HW module
min: None # No HW module
max: None # No HW module
unit: (instr + $normUnit)
tips:
F16-Mult:
count: None # No perf counter
avg: None # No HW module
min: None # No HW module
max: None # No HW module
unit: (instr + $normUnit)
tips:
F16-FMA:
count: None # No perf counter
avg: None # No HW module
min: None # No HW module
max: None # No HW module
unit: (instr + $normUnit)
tips:
F16-Trans:
count: None # No perf counter
avg: None # No HW module
min: None # No HW module
max: None # No HW module
unit: (instr + $normUnit)
tips:
F32-ADD:
count: None # No perf counter
avg: None # No HW module
min: None # No HW module
max: None # No HW module
unit: (instr + $normUnit)
tips:
F32-Mult:
count: None # No perf counter
avg: None # No HW module
min: None # No HW module
max: None # No HW module
unit: (instr + $normUnit)
tips:
F32-FMA:
count: None # No perf counter
avg: None # No HW module
min: None # No HW module
max: None # No HW module
unit: (instr + $normUnit)
tips:
F32-Trans:
count: None # No perf counter
avg: None # No HW module
min: None # No HW module
max: None # No HW module
unit: (instr + $normUnit)
tips:
F64-ADD:
count: None # No perf counter
avg: None # No HW module
min: None # No HW module
max: None # No HW module
unit: (instr + $normUnit)
tips:
F64-Mult:
count: None # No perf counter
avg: None # No HW module
min: None # No HW module
max: None # No HW module
unit: (instr + $normUnit)
tips:
F64-FMA:
count: None # No perf counter
avg: None # No HW module
min: None # No HW module
max: None # No HW module
unit: (instr + $normUnit)
tips:
F64-Trans:
count: None # No perf counter
avg: None # No HW module
min: None # No HW module
max: None # No HW module
unit: (instr + $normUnit)
tips:
Conversion:
count: None # No perf counter
avg: None # No HW module
min: None # No HW module
max: None # No HW module
unit: (instr + $normUnit)
tips:

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,43 +13,61 @@ Panel Config:
title: Instruction Mix
header:
metric: Metric
count: Count
avg: Avg
min: Min
max: Max
unit: Unit
tips: Tips
style:
type: simple_bar
label_txt: (# of instr + $normUnit)
metric:
VALU - Vector:
count: AVG(((SQ_INSTS_VALU - SQ_INSTS_MFMA) / $denom))
avg: AVG(((SQ_INSTS_VALU - SQ_INSTS_MFMA) / $denom))
min: MIN(((SQ_INSTS_VALU - SQ_INSTS_MFMA) / $denom))
max: MAX(((SQ_INSTS_VALU - SQ_INSTS_MFMA) / $denom))
unit: (instr + $normUnit)
tips:
VMEM:
count: AVG(((SQ_INSTS_VMEM - SQ_INSTS_FLAT_LDS_ONLY) / $denom))
avg: AVG(((SQ_INSTS_VMEM - SQ_INSTS_FLAT_LDS_ONLY) / $denom))
min: MIN(((SQ_INSTS_VMEM - SQ_INSTS_FLAT_LDS_ONLY) / $denom))
max: MAX(((SQ_INSTS_VMEM - SQ_INSTS_FLAT_LDS_ONLY) / $denom))
unit: (instr + $normUnit)
tips:
LDS:
count: AVG((SQ_INSTS_LDS / $denom))
avg: AVG((SQ_INSTS_LDS / $denom))
min: MIN((SQ_INSTS_LDS / $denom))
max: MAX((SQ_INSTS_LDS / $denom))
unit: (instr + $normUnit)
tips:
VALU - MFMA:
count: None # No HW module
avg: None # No HW module
min: None # No HW module
max: None # No HW module
unit: (instr + $normUnit)
tips:
SALU:
count: AVG((SQ_INSTS_SALU / $denom))
avg: AVG((SQ_INSTS_SALU / $denom))
min: MIN((SQ_INSTS_SALU / $denom))
max: MAX((SQ_INSTS_SALU / $denom))
unit: (instr + $normUnit)
tips:
SMEM:
count: AVG((SQ_INSTS_SMEM / $denom))
avg: AVG((SQ_INSTS_SMEM / $denom))
min: MIN((SQ_INSTS_SMEM / $denom))
max: MAX((SQ_INSTS_SMEM / $denom))
unit: (instr + $normUnit)
tips:
Branch:
count: AVG((SQ_INSTS_BRANCH / $denom))
avg: AVG((SQ_INSTS_BRANCH / $denom))
min: MIN((SQ_INSTS_BRANCH / $denom))
max: MAX((SQ_INSTS_BRANCH / $denom))
unit: (instr + $normUnit)
tips:
GDS:
count: AVG((SQ_INSTS_GDS / $denom))
avg: AVG((SQ_INSTS_GDS / $denom))
min: MIN((SQ_INSTS_GDS / $denom))
max: MAX((SQ_INSTS_GDS / $denom))
unit: (instr + $normUnit)
tips:

Expand All @@ -58,71 +76,103 @@ Panel Config:
title: VALU Arithmetic Instr Mix
header:
metric: Metric
count: Count
avg: Avg
min: Min
max: Max
unit: Unit
tips: Tips
style:
type: simple_bar
label_txt: (# of instr + $normUnit)
metric:
INT-32:
count: None # No perf counter
avg: None # No perf counter
min: None # No perf counter
max: None # No perf counter
unit: (instr + $normUnit)
tips:
INT-64:
count: None # No perf counter
avg: None # No perf counter
min: None # No perf counter
max: None # No perf counter
unit: (instr + $normUnit)
tips:
F16-ADD:
count: None # No perf counter
avg: None # No perf counter
min: None # No perf counter
max: None # No perf counter
unit: (instr + $normUnit)
tips:
F16-Mult:
count: None # No perf counter
avg: None # No perf counter
min: None # No perf counter
max: None # No perf counter
unit: (instr + $normUnit)
tips:
F16-FMA:
count: None # No perf counter
avg: None # No perf counter
min: None # No perf counter
max: None # No perf counter
unit: (instr + $normUnit)
tips:
F16-Trans:
count: None # No perf counter
avg: None # No perf counter
min: None # No perf counter
max: None # No perf counter
unit: (instr + $normUnit)
tips:
F32-ADD:
count: None # No perf counter
avg: None # No perf counter
min: None # No perf counter
max: None # No perf counter
unit: (instr + $normUnit)
tips:
F32-Mult:
count: None # No perf counter
avg: None # No perf counter
min: None # No perf counter
max: None # No perf counter
unit: (instr + $normUnit)
tips:
F32-FMA:
count: None # No perf counter
avg: None # No perf counter
min: None # No perf counter
max: None # No perf counter
unit: (instr + $normUnit)
tips:
F32-Trans:
count: None # No perf counter
avg: None # No perf counter
min: None # No perf counter
max: None # No perf counter
unit: (instr + $normUnit)
tips:
F64-ADD:
count: None # No perf counter
avg: None # No perf counter
min: None # No perf counter
max: None # No perf counter
unit: (instr + $normUnit)
tips:
F64-Mult:
count: None # No perf counter
avg: None # No perf counter
min: None # No perf counter
max: None # No perf counter
unit: (instr + $normUnit)
tips:
F64-FMA:
count: None # No perf counter
avg: None # No perf counter
min: None # No perf counter
max: None # No perf counter
unit: (instr + $normUnit)
tips:
F64-Trans:
count: None # No perf counter
avg: None # No perf counter
min: None # No perf counter
max: None # No perf counter
unit: (instr + $normUnit)
tips:
Conversion:
count: None # No perf counter
avg: None # No perf counter
min: None # No perf counter
max: None # No perf counter
unit: (instr + $normUnit)
tips:

Expand Down
Loading
Loading