Bw smart units new #161
Closed
Bw smart units new #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoseSantosAMD
force-pushed
the
bw_smart_units_new
branch
from
a6085ef
to
f64691e
Compare
|
The changes made don't account for the baseline comparison edge case, i.e. $ omniperf analyze -p workloads/mix/mi200/ -p workloads/vcopy/mi200/ -b 2.1.22
Index │ Metric │ Value │ Value │ Unit │ Peak │ Peak │ PoP │ PoP │
2.1.22 │ L2-Fabric Read BW │ 50.0 │ 0.14 (-99.72%) │ Mb/s │ 1638.4 │ 1638.4 (0.0%) │ 0.0 │ 0.01 (inf%) This example illustrates the fact that the "smart unit" will be determined by the first workload, but the second workload is still in unchanged Gb/s form. Please revisit this. |
Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com>
tested with --gui and --cli Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com>
Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com>
Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com>
JoseSantosAMD
force-pushed
the
bw_smart_units_new
branch
from
7173d06
to
c5aa3d3
Compare
Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com>
Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com>
Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com>
|
Stale branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #145