Pytest update metrics #264
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com>
Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com>
Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com>
Signed-off-by: colramos-amd <colramos@amd.com>
- add check device count in check_csv_files - reformat Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com>
Signed-off-by: colramos-amd <colramos@amd.com>
Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com>
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
subset of calls to rocm-smi Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
Signed-off-by: colramos-amd <colramos@amd.com>
Co-authored-by: Nick Curtis <nicholas.curtis@amd.com> Signed-off-by: colramos-amd <colramos@amd.com>
Co-authored-by: Nick Curtis <nicholas.curtis@amd.com> Signed-off-by: colramos-amd <colramos@amd.com>
Co-authored-by: Nick Curtis <nicholas.curtis@amd.com> Signed-off-by: colramos-amd <colramos@amd.com>
Co-authored-by: Nick Curtis <nicholas.curtis@amd.com> Signed-off-by: colramos-amd <colramos@amd.com>
Co-authored-by: Nick Curtis <nicholas.curtis@amd.com> Signed-off-by: colramos-amd <colramos@amd.com>
Co-authored-by: Nick Curtis <nicholas.curtis> Signed-off-by: colramos-amd <colramos@amd.com>
Signed-off-by: colramos-amd <colramos@amd.com>
Signed-off-by: colramos-amd <colramos@amd.com>
Signed-off-by: colramos-amd <colramos@amd.com>
Signed-off-by: colramos-amd <colramos@amd.com>
…d build will function (ROCm#240) Signed-off-by: Nicholas Curtis <nicurtis@amd.com> Co-authored-by: Nicholas Curtis <nicurtis@amd.com>
* escape sbios, can have commas on some systems Signed-off-by: Nicholas Curtis <nicurtis@amd.com> * Prefer to cast to str in original function Signed-off-by: colramos-amd <colramos@amd.com> --------- Signed-off-by: Nicholas Curtis <nicurtis@amd.com> Signed-off-by: colramos-amd <colramos@amd.com> Co-authored-by: Nicholas Curtis <nicurtis@amd.com> Co-authored-by: colramos-amd <colramos@amd.com>
Signed-off-by: colramos-amd <colramos@amd.com>
Signed-off-by: colramos-amd <colramos@amd.com>
Signed-off-by: colramos-amd <colramos@amd.com>
Signed-off-by: colramos-amd <colramos@amd.com>
Signed-off-by: colramos-amd <colramos@amd.com>
Signed-off-by: colramos-amd <colramos@amd.com>
* Fix hbmBW calculation, currently we're reading the wrong value of the mclk out of rocm-smi Signed-off-by: Nicholas Curtis <nicurtis@amd.com> * Fix for earlier smi Signed-off-by: Nicholas Curtis <nicurtis@amd.com> --------- Signed-off-by: Nicholas Curtis <nicurtis@amd.com> Co-authored-by: Nicholas Curtis <nicurtis@amd.com>
Signed-off-by: Nicholas Curtis <nicurtis@amd.com> Co-authored-by: Nicholas Curtis <nicurtis@amd.com>
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
pytest markers and define a new "analyze_commands" label to support parallel execution Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
Signed-off-by: Jose Santos <josantos@t004-002.hpcfund
Signed-off-by: Jose Santos <josantos@login1.hpcfund>
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
Signed-off-by: Jose Santos <josantos@login1.hpcfund>
Signed-off-by: JoseSantosAMD <87447437+JoseSantosAMD@users.noreply.github.com>
|
@JoseSantosAMD, I'm having a mess of a time with patching this in cleanly. Can I bother you to create a fresh branch against latest 2.x and redo this PR to update underlying metrics to test against? |
|
Superseded by #265 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.