-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rocprof-compute branding update #428
base: amd-staging
Are you sure you want to change the base?
rocprof-compute branding update #428
Conversation
6265391
to
0d15023
Compare
Subtask
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See requested subtask above
48152d6
to
8062ae1
Compare
9753c80
to
0e7085c
Compare
ff39865
to
6b53298
Compare
ac3de62
to
3417f50
Compare
c32a9a1
to
8e4e774
Compare
4644a79
to
ecaf46a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is in no way an expansive review (I haven't even tried running this code). There are quite a few issues that I caught upon first glance, including some that should have been caught with a basic ctrl+f
which makes me suspicious.
I'd like a few others to review before we merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you need to change the name of this file and all files in grafana/dashboards/*.json
?
@xuchen-amd , it looks like you have some unintended changes after rebasing and resolving the merge conflicts. |
Omniperf analyze expects the accumulate files to be in SQ_*.csv files. Since these files also contain PMC counters (we are trying to fit as many counters into each file as possible to minimize runs), we need to include these SQ_*.csv files in pmc_perf.csv. Signed-off-by: benrichard-amd <ben.richard@amd.com> Signed-off-by: xuchen-amd <xuchen@amd.com>
Signed-off-by: benrichard-amd <ben.richard@amd.com> Signed-off-by: xuchen-amd <xuchen@amd.com>
Signed-off-by: benrichard-amd <ben.richard@amd.com> Signed-off-by: xuchen-amd <xuchen@amd.com>
Signed-off-by: xuchen-amd <xuchen@amd.com>
Signed-off-by: xuchen-amd <xuchen@amd.com>
Signed-off-by: xuchen-amd <xuchen@amd.com>
Signed-off-by: xuchen-amd <xuchen@amd.com>
…md/omniperf into rocprof-compute_branding_update
Co-authored-by: David Galiffi <David.Galiffi@amd.com> Signed-off-by: xuchen-amd <xuchen@amd.com>
Co-authored-by: David Galiffi <David.Galiffi@amd.com> Signed-off-by: xuchen-amd <xuchen@amd.com>
Co-authored-by: David Galiffi <David.Galiffi@amd.com> Signed-off-by: xuchen-amd <xuchen@amd.com>
Co-authored-by: David Galiffi <David.Galiffi@amd.com> Signed-off-by: xuchen-amd <xuchen@amd.com>
…md/omniperf into rocprof-compute_branding_update
Co-authored-by: David Galiffi <David.Galiffi@amd.com> Signed-off-by: xuchen-amd <xuchen@amd.com>
Co-authored-by: David Galiffi <David.Galiffi@amd.com> Signed-off-by: xuchen-amd <xuchen@amd.com>
Co-authored-by: David Galiffi <David.Galiffi@amd.com> Signed-off-by: xuchen-amd <xuchen@amd.com>
Co-authored-by: David Galiffi <David.Galiffi@amd.com> Signed-off-by: xuchen-amd <xuchen@amd.com>
Co-authored-by: David Galiffi <David.Galiffi@amd.com> Signed-off-by: xuchen-amd <xuchen@amd.com>
…md/omniperf into rocprof-compute_branding_update
Co-authored-by: David Galiffi <David.Galiffi@amd.com> Signed-off-by: xuchen-amd <xuchen@amd.com>
No description provided.