rocprof-compute branding update #428

xuchen-amd · 2024-09-24T15:44:06Z

No description provided.

coleramos425 · 2024-10-02T20:30:42Z

Subtask

Publish Omniperf's Grafana Docker image to DockerHub under "rocprof-compute" name (Provide Grafana + Omniperf plugin as Docker image in a public registry like Dockerhub #418) (CC: @njobypet)

coleramos425

See requested subtask above

cmake/omniperf.lua.in

CMakeLists.txt

.github/workflows/tarball.yml

.github/workflows/packaging.yml

.github/workflows/tarball.yml

.github/workflows/packaging.yml

grafana/dashboards/Omniperf_v1.0.5_pub.json

README.md

.azuredevops/rocm-ci.yml

coleramos425

This is in no way an expansive review (I haven't even tried running this code). There are quite a few issues that I caught upon first glance, including some that should have been caught with a basic ctrl+f which makes me suspicious.

I'd like a few others to review before we merge.

.github/workflows/dependabot.yml

.github/workflows/docs.yml

CHANGELOG.md

CMakeLists.txt

docs/conf.py

docs/tutorial/profiling-by-example.rst

coleramos425 · 2024-10-23T17:53:48Z

grafana/dashboards/Omniperf_v1.0.5_pub.json

Do you need to change the name of this file and all files in grafana/dashboards/*.json?

grafana/plugins/omniperf_plugin/src/plugin.json

src/rocprof_compute_base.py

src/rocprof_compute_soc/soc_base.py

dgaliffiAMD · 2024-10-23T18:27:28Z

@xuchen-amd , it looks like you have some unintended changes after rebasing and resolving the merge conflicts.

CMakeLists.txt

Omniperf analyze expects the accumulate files to be in SQ_*.csv files. Since these files also contain PMC counters (we are trying to fit as many counters into each file as possible to minimize runs), we need to include these SQ_*.csv files in pmc_perf.csv. Signed-off-by: benrichard-amd <ben.richard@amd.com> Signed-off-by: xuchen-amd <xuchen@amd.com>

Signed-off-by: benrichard-amd <ben.richard@amd.com> Signed-off-by: xuchen-amd <xuchen@amd.com>

Signed-off-by: xuchen-amd <xuchen@amd.com>

…ofile.

…md/omniperf into rocprof-compute_branding_update

tests/test_profile_general.py

README.md

CHANGELOG.md

.github/workflows/docs.yml

.github/CODEOWNERS

.github/ISSUE_TEMPLATE/bug_report.md

Co-authored-by: David Galiffi <David.Galiffi@amd.com> Signed-off-by: xuchen-amd <xuchen@amd.com>

…md/omniperf into rocprof-compute_branding_update

Co-authored-by: David Galiffi <David.Galiffi@amd.com> Signed-off-by: xuchen-amd <xuchen@amd.com>

…md/omniperf into rocprof-compute_branding_update

Co-authored-by: David Galiffi <David.Galiffi@amd.com> Signed-off-by: xuchen-amd <xuchen@amd.com>

xuchen-amd requested review from a team, koomie and coleramos425 as code owners September 24, 2024 15:44

coleramos425 force-pushed the amd-staging branch from 6265391 to 0d15023 Compare September 25, 2024 17:24

coleramos425 mentioned this pull request Oct 2, 2024

Provide Grafana + Omniperf plugin as Docker image in a public registry like Dockerhub #418

Open

coleramos425 requested changes Oct 2, 2024

View reviewed changes

peterjunpark mentioned this pull request Oct 3, 2024

Update branding in documentation #442

Open

dgaliffiAMD requested changes Oct 10, 2024

View reviewed changes

dgaliffiAMD reviewed Oct 10, 2024

View reviewed changes

grafana/dashboards/Omniperf_v1.0.5_pub.json Show resolved Hide resolved

coleramos425 self-requested a review October 11, 2024 20:27

xuchen-amd requested a review from feizheng10 as a code owner October 16, 2024 16:25

xuchen-amd force-pushed the rocprof-compute_branding_update branch from 48152d6 to 8062ae1 Compare October 16, 2024 20:05

dgaliffiAMD reviewed Oct 16, 2024

View reviewed changes

README.md Outdated Show resolved Hide resolved

xuchen-amd force-pushed the rocprof-compute_branding_update branch from 9753c80 to 0e7085c Compare October 17, 2024 00:19

dgaliffiAMD approved these changes Oct 17, 2024

View reviewed changes

dgaliffiAMD reviewed Oct 17, 2024

View reviewed changes

README.md Show resolved Hide resolved

danielsu-amd reviewed Oct 18, 2024

View reviewed changes

.azuredevops/rocm-ci.yml Outdated Show resolved Hide resolved

xuchen-amd force-pushed the rocprof-compute_branding_update branch from ff39865 to 6b53298 Compare October 22, 2024 01:39

dgaliffiAMD force-pushed the rocprof-compute_branding_update branch from ac3de62 to 3417f50 Compare October 23, 2024 02:00

xuchen-amd force-pushed the rocprof-compute_branding_update branch from c32a9a1 to 8e4e774 Compare October 23, 2024 05:43

dgaliffiAMD approved these changes Oct 23, 2024

View reviewed changes

xuchen-amd force-pushed the rocprof-compute_branding_update branch from 4644a79 to ecaf46a Compare October 23, 2024 15:25

coleramos425 requested changes Oct 23, 2024

View reviewed changes

dgaliffiAMD self-requested a review October 23, 2024 18:28

dgaliffiAMD reviewed Oct 24, 2024

View reviewed changes

CMakeLists.txt Outdated Show resolved Hide resolved

benrichard-amd added 3 commits October 29, 2024 00:34

Update to work with rocprof v1

40d4e65

Signed-off-by: benrichard-amd <ben.richard@amd.com> Signed-off-by: xuchen-amd <xuchen@amd.com>

Remove unused method

b31fa31

Signed-off-by: benrichard-amd <ben.richard@amd.com> Signed-off-by: xuchen-amd <xuchen@amd.com>

xuchen-amd added 14 commits October 29, 2024 01:05

Fix executable name.

3b8e292

Signed-off-by: xuchen-amd <xuchen@amd.com>

Fix conflicts.

e9f06a2

Signed-off-by: xuchen-amd <xuchen@amd.com>

Fix CMakeLists.

0159e09

Signed-off-by: xuchen-amd <xuchen@amd.com>

Fix tarball.

0241139

Signed-off-by: xuchen-amd <xuchen@amd.com>

Fix duplication issues.

7728043

Resolve reviews.

2ae1ed9

Revert unintended changes in rocprof_compute_analyze.

1b30b3d

Rename OmniProfiler_Base to RocProfCompute_Base in rocprof_compute_pr…

63bb7dc

…ofile.

Revert unintended changes in rocprof_compute_soc.

dcce38a

Revert unintended changes in tests\workloads\multikernel\MI200.

e3dc685

Fix format + rename env to ROCPROFCOMPUTE*.

de9bf3b

Move rocprofcompute.lua.in to its correct location.

344e09d

Merge branch 'rocprof-compute_branding_update' of github.com:xuchen-a…

1a1a7a9

…md/omniperf into rocprof-compute_branding_update

Fix python formatting.

1dbe560

dgaliffiAMD requested changes Oct 29, 2024

View reviewed changes

xuchen-amd and others added 15 commits October 29, 2024 15:12

Remove unintended changes.

14b3dbe

Update docs/tutorial/profiling-by-example.rst

9dc2a78

Co-authored-by: David Galiffi <David.Galiffi@amd.com> Signed-off-by: xuchen-amd <xuchen@amd.com>

Update .github/workflows/docs.yml

d00ea74

Co-authored-by: David Galiffi <David.Galiffi@amd.com> Signed-off-by: xuchen-amd <xuchen@amd.com>

Update CHANGELOG.md

f28ed48

Co-authored-by: David Galiffi <David.Galiffi@amd.com> Signed-off-by: xuchen-amd <xuchen@amd.com>

Update README.md

f4ad866

Co-authored-by: David Galiffi <David.Galiffi@amd.com> Signed-off-by: xuchen-amd <xuchen@amd.com>

Remove duplicates and fix unintended removal.

923e4eb

Merge branch 'rocprof-compute_branding_update' of github.com:xuchen-a…

705ed7a

…md/omniperf into rocprof-compute_branding_update

Update src/utils/specs.py

5c029d0

Co-authored-by: David Galiffi <David.Galiffi@amd.com> Signed-off-by: xuchen-amd <xuchen@amd.com>

Update docs/tutorial/includes/vector-memory-operation-counting.rst

d35c21c

Co-authored-by: David Galiffi <David.Galiffi@amd.com> Signed-off-by: xuchen-amd <xuchen@amd.com>

Update docs/conf.py

9e0740f

Co-authored-by: David Galiffi <David.Galiffi@amd.com> Signed-off-by: xuchen-amd <xuchen@amd.com>

Update docs/tutorial/includes/infinity-fabric-transactions.rst

d6f6428

Co-authored-by: David Galiffi <David.Galiffi@amd.com> Signed-off-by: xuchen-amd <xuchen@amd.com>

Update docs/tutorial/includes/occupancy-limiters-example.rst

213a36c

Co-authored-by: David Galiffi <David.Galiffi@amd.com> Signed-off-by: xuchen-amd <xuchen@amd.com>

Fix unintended changes.

d3a5f2c

Merge branch 'rocprof-compute_branding_update' of github.com:xuchen-a…

f2c3d0e

…md/omniperf into rocprof-compute_branding_update

Update docs/how-to/profile/mode.rst

ab12160

Co-authored-by: David Galiffi <David.Galiffi@amd.com> Signed-off-by: xuchen-amd <xuchen@amd.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

rocprof-compute branding update #428

rocprof-compute branding update #428

xuchen-amd commented Sep 24, 2024 •

edited

Loading

coleramos425 commented Oct 2, 2024 •

edited by xuchen-amd

Loading

coleramos425 left a comment

coleramos425 left a comment

coleramos425 Oct 23, 2024

dgaliffiAMD commented Oct 23, 2024

rocprof-compute branding update #428

Are you sure you want to change the base?

rocprof-compute branding update #428

Conversation

xuchen-amd commented Sep 24, 2024 • edited Loading

coleramos425 commented Oct 2, 2024 • edited by xuchen-amd Loading

Subtask

coleramos425 left a comment

Choose a reason for hiding this comment

coleramos425 left a comment

Choose a reason for hiding this comment

coleramos425 Oct 23, 2024

Choose a reason for hiding this comment

dgaliffiAMD commented Oct 23, 2024

xuchen-amd commented Sep 24, 2024 •

edited

Loading

coleramos425 commented Oct 2, 2024 •

edited by xuchen-amd

Loading