Use MI300 chip_id instead of model to detect XCD count #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a previous change we started using "MI300" for gpu_model instead of the full "MI300X_A0" or "MI300X_A1", etc. The XCD detection code was using gpu_model and expecting the full name, causing the XCD count = 1. Passing chip_id fixes the issue. Signed-off-by: benrichard-amd <ben.richard@amd.com>
feizheng10
approved these changes
Oct 16, 2024
xuchen-amd
pushed a commit
to xuchen-amd/omniperf
that referenced
this pull request
Oct 19, 2024
In a previous change we started using "MI300" for gpu_model instead of the full "MI300X_A0" or "MI300X_A1", etc. The XCD detection code was using gpu_model and expecting the full name, causing the XCD count = 1. Passing chip_id fixes the issue. Signed-off-by: benrichard-amd <ben.richard@amd.com> Signed-off-by: xuchen-amd <xuchen@amd.com>
xuchen-amd
pushed a commit
to xuchen-amd/omniperf
that referenced
this pull request
Oct 22, 2024
In a previous change we started using "MI300" for gpu_model instead of the full "MI300X_A0" or "MI300X_A1", etc. The XCD detection code was using gpu_model and expecting the full name, causing the XCD count = 1. Passing chip_id fixes the issue. Signed-off-by: benrichard-amd <ben.richard@amd.com> Signed-off-by: xuchen-amd <xuchen@amd.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a previous change we began using "MI300" for gpu_model instead of the full "MI300X_A0" or "MI300X_A1", etc.
The XCD detection code was receiving gpu_model and expecting the full name, causing the XCD count = 1 and several metrics to be off by a factor of 8 (e.g. VALU utilization, wavefront occupancy).
Passing chip_id instead of gpu_model fixes the issue.