Add broken mclk workaround for all arch #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: benrichard-amd <ben.richard@amd.com>
benrichard-amd
requested review from
coleramos425,
feizheng10 and
dgaliffiAMD
as code owners
feizheng10
approved these changes
Oct 25, 2024
coleramos425
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some time ago there was a rocm-smi version that failed to report mclk frequencies, causing omniperf to crash. And in the MI100 case, mclk has never worked.
People are still running into these issues often enough that it makes sense to add the workaround into Omniperf.
Tested on MI100/MI210/MI300X.