Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MI300 Roofline Enablement in Omniperf #454

Open
wants to merge 1 commit into
base: amd-staging
Choose a base branch
from

Conversation

cfallows-amd
Copy link
Contributor

requirements.txt

  • running some modules complained about numpy version too new, adding extra requirement that numpy be 1.x pmc_roof_perf.txt
  • adding TCC_BUBBLE_sum counter to profile soc_gfx940.py
    soc_gfx941.py
    soc_gfx942.py
  • add workaround for max and current mclk to 1300MHz, cannot be read at this time from tool
  • remove console logs reading that roofline is temporarily disabled, uncommenting blocks that check for roofline csv and run roofline post-processing roofline_calc.py
  • add mi300 to supported soc
  • add new calculation for hbm_data for MI300 using tcc_bubble_sum, checks if counter > 0 to use
  • add to a few comments roofline-ubuntu-20_04-mi300-rocm6
  • binary for the ubuntu systems to enable mi300 roofline calculations from rocm-amdgpu-bench

Note- other distros will get roofline bins to enable mi300, but need to be further tested before putting into branch.

requirements.txt
- running some modules complained about numpy version too new, adding extra requirement that numpy be 1.x
pmc_roof_perf.txt
- adding TCC_BUBBLE_sum counter to profile
soc_gfx940.py
soc_gfx941.py
soc_gfx942.py
- add workaround for max and current mclk to 1300MHz, cannot be read at this time from tool
- remove console logs reading that roofline is temporarily disabled, uncommenting blocks that check for roofline csv and run roofline post-processing
roofline_calc.py
- add mi300 to supported soc
- add new calculation for hbm_data for MI300 using tcc_bubble_sum, checks if counter > 0 to use
- add to a few comments
roofline-ubuntu-20_04-mi300-rocm6
- binary for the ubuntu systems to enable mi300 roofline calculations from rocm-amdgpu-bench

Note- other distros will get roofline bins to enable mi300, but need to be further tested before putting into branch.

Signed-off-by: Carrie Fallows <carrie.fallows@amd.com>
@coleramos425
Copy link
Collaborator

Overall, this looks good. My only comments are:

  1. The workaround for MCLK fixed to 1300 MHz. Is this related to broken --showmclkrange ticket? If so, we should reconnect with rocm-smi team because this issue is likely affecting many other projects. Any reason the old conditional we had in place wasn't sufficient?
    # if self._mspec.gpu_model in ["MI308X", "MI300X_A1", "MI300A_A1"]:
    self._mspec.max_mclk = 1300
    self._mspec.cur_mclk = 1300
  2. Still need Python formatting via Black formatter (i.e. black --diff --check .)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants