-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch for omnitrace-sample crash with HIP API. #344
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except the variable initialization
Removed the unnecessary else. |
Check if stack is empty before popping data off of it. Signed-off-by: Aleksandar Janicijevic <Aleksandar.Janicijevic@amd.com>
Sorry, the previous commit was not signed properly. I amended that commit and now it is signed, but that removed your approval. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. All verified now. I'm still not sure why there is that second merge commit, though.
I think that is because the main branch on my fork was behind the main branch on the omnitrace repo, so I had to merge this morning. |
No description provided.