Patch for omnitrace-sample crash with HIP API. #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrmadsen
requested changes
Jun 6, 2024
jrmadsen
previously approved these changes
Jun 6, 2024
dgaliffiAMD
previously approved these changes
Jun 6, 2024
|
Removed the unnecessary else. |
dgaliffiAMD
previously approved these changes
Jun 7, 2024
jrmadsen
previously approved these changes
Jun 7, 2024
Check if stack is empty before popping data off of it. Signed-off-by: Aleksandar Janicijevic <Aleksandar.Janicijevic@amd.com>
|
Sorry, the previous commit was not signed properly. I amended that commit and now it is signed, but that removed your approval. |
dgaliffiAMD
approved these changes
Jun 7, 2024
|
I think that is because the main branch on my fork was behind the main branch on the omnitrace repo, so I had to merge this morning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.