Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Perfetto and fix tests #378

Merged
merged 50 commits into from
Sep 13, 2024
Merged

Conversation

ajanicijamd
Copy link
Contributor

@ajanicijamd ajanicijamd commented Sep 6, 2024

Fix for "SWDEV-479652" - Perfetto-based tests are failing.

  • Updated version of perfetto submodule to v46.0.
  • Modified Omnitrace code that uses Perfetto so it can compile.
  • Modified the testing code so it can run the built version of trace_processor_shell.

Adding DOMNITRACE_INSTALL_PERFETTO_TOOLS=ON to ubuntu-jammy workflow
dgaliffiAMD and others added 23 commits September 8, 2024 12:51
This warning / error is generated when we also compile the
perfetto tools: /src/trace_processor/trace_processor_shell.c

Signed-off-by: David Galiffi <David.Galiffi@amd.com>
Signed-off-by: David Galiffi <David.Galiffi@amd.com>
Signed-off-by: David Galiffi <David.Galiffi@amd.com>
Signed-off-by: David Galiffi <David.Galiffi@amd.com>
This reverts commit 891a199.

We'll move this to it's own PR.
Remove the INSTALL_PERFETTO_TOOLS and
add `pip install --upgrade perfetto`

Signed-off-by: David Galiffi <David.Galiffi@amd.com>
Check if the provided path to trace_processor is valid before using
Enable verbose logging for testing

Signed-off-by: David Galiffi <David.Galiffi@amd.com>
Signed-off-by: David Galiffi <David.Galiffi@amd.com>
Signed-off-by: David Galiffi <David.Galiffi@amd.com>
Signed-off-by: David Galiffi <David.Galiffi@amd.com>
Signed-off-by: David Galiffi <David.Galiffi@amd.com>
Signed-off-by: David Galiffi <David.Galiffi@amd.com>
@dgaliffiAMD dgaliffiAMD changed the title Fix to make Perfetto tests in Omnitrace pass Update Perfetto and fix tests Sep 13, 2024
@dgaliffiAMD
Copy link
Collaborator

FYI - I just removed the internal JIRA link from the commit description.

@dgaliffiAMD dgaliffiAMD merged commit 96d7b8f into ROCm:main Sep 13, 2024
42 checks passed
@ajanicijamd ajanicijamd deleted the SWDEV-479652-perfetto branch September 13, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants