Skip to content

Commit

Permalink
AOTriton: download binary from github, NO BUILD FROM SOURCE option
Browse files Browse the repository at this point in the history
    Fix tarball's suffix

    Read rocm version from variables set by LoadHIP.cmake

    Copy AOTRITON_INSTALLED_PREFIX/* to torch/

    Otherwise bdist_wheel will miss libaotriton_v2.so

    Fix problems in aotriton.cmake

    Guard against new ROCM environment

    This also updates aotriton_version.txt's format

    Supply ROCM versions and SHA256 checksums as lists.

    Let install_aotriton.sh parse the new format of aotriton_version.txt

    Do not hardcode __AOTRITON_ARCH

    Updates to aotriton build steps and Dockerfiles (#1599)

Changes cherry-picked from pytorch#137443
  • Loading branch information
jithunnair-amd committed Oct 9, 2024
1 parent 383a20e commit a3ef66b
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 26 deletions.
5 changes: 0 additions & 5 deletions .ci/docker/aotriton_version.txt

This file was deleted.

3 changes: 3 additions & 0 deletions .ci/docker/centos-rocm/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -115,13 +115,16 @@ COPY triton_version.txt triton_version.txt
RUN if [ -n "${TRITON}" ]; then bash ./install_triton.sh; fi
RUN rm install_triton.sh common_utils.sh triton-rocm.txt triton_version.txt

<<<<<<< HEAD
# Install AOTriton (Early fail)
COPY ./aotriton_version.txt aotriton_version.txt
COPY ./common/common_utils.sh common_utils.sh
COPY ./common/install_aotriton.sh install_aotriton.sh
RUN ["/bin/bash", "-c", "./install_aotriton.sh /opt/rocm && rm -rf install_aotriton.sh aotriton_version.txt common_utils.sh"]
ENV AOTRITON_INSTALLED_PREFIX /opt/rocm/aotriton

=======
>>>>>>> 94e2aab0ed (AOTriton: download binary from github, NO BUILD FROM SOURCE option)
# Install ccache/sccache (do this last, so we get priority in PATH)
COPY ./common/install_cache.sh install_cache.sh
ENV PATH /opt/cache/bin:$PATH
Expand Down
21 changes: 0 additions & 21 deletions .ci/docker/common/install_aotriton.sh

This file was deleted.

3 changes: 3 additions & 0 deletions .ci/docker/ubuntu-rocm/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -105,13 +105,16 @@ COPY triton_version.txt triton_version.txt
RUN if [ -n "${TRITON}" ]; then bash ./install_triton.sh; fi
RUN rm install_triton.sh common_utils.sh triton-rocm.txt triton_version.txt

<<<<<<< HEAD
# Install AOTriton
COPY ./aotriton_version.txt aotriton_version.txt
COPY ./common/common_utils.sh common_utils.sh
COPY ./common/install_aotriton.sh install_aotriton.sh
RUN ["/bin/bash", "-c", "./install_aotriton.sh /opt/rocm && rm -rf install_aotriton.sh aotriton_version.txt common_utils.sh"]
ENV AOTRITON_INSTALLED_PREFIX /opt/rocm/aotriton

=======
>>>>>>> 94e2aab0ed (AOTriton: download binary from github, NO BUILD FROM SOURCE option)
# Install ccache/sccache (do this last, so we get priority in PATH)
COPY ./common/install_cache.sh install_cache.sh
ENV PATH /opt/cache/bin:$PATH
Expand Down

0 comments on commit a3ef66b

Please sign in to comment.