forked from pytorch/pytorch
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uvm backend #1174
Draft
dllehr-amd
wants to merge
9
commits into
ROCm:master
Choose a base branch
from
dllehr-amd:uvm_backend
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Uvm backend #1174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dllehr-amd
commented
Feb 7, 2023
With the new CUDAAllocator class, we have created a new CUDAMallocManagedAllocator, which will handle allocator requests from both cpu and cuda device types when the backend is enabled You can enable the backend using PYTORCH_CUDA_ALLOC_CONF=backend:cudaMallocManaged And view inside PyTorch using torch.cuda.get_allocator_backend() This allocator is initially rudimentary as the performance implications of a managed allocator are still being worked out. However, the goal is to be able to swap out the backend when running without any code change required.
jayfurmanek
reviewed
Feb 7, 2023
aten/src/ATen/cuda/EmptyTensor.cpp
Outdated
@@ -1,6 +1,7 @@ | |||
#define TORCH_ASSERT_NO_OPERATORS | |||
#include <ATen/cuda/EmptyTensor.h> | |||
#include <ATen/cuda/CUDAContext.h> | |||
#include <ATen/cuda/UvmMemoryAllocator.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Header no longer needed
Jenkins build for 12328b5cb5a7d607210f366cc828d5836dad05d4 commit finished as FAILURE |
Jenkins build for 12328b5cb5a7d607210f366cc828d5836dad05d4 commit finished as FAILURE |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.