-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
draft: remove failing assertions #6
base: amd-mainline
Are you sure you want to change the base?
Conversation
remove comment containing 'johnmc'
remove comment containing 'johnmc'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jmellorcrummey, I think these should just move down below the tracing::populate_external_correlation_ids(…)
function call that is a little further down in the code.
Actually, I was mistaken. It appears this condition can arise if you are using both callback and buffer tracing of an API in the same context:
which ends up with one external correlation id map entry, one callback entry, and one buffer entry. Are you intentionally doing this? |
We are intentionally doing this at present. It should be allowed. That's why I think the assertion should be deleted. For the future, we aim to switch to the external correlation id support rather than using the callback. |
aovid the need to patch AMD's amdgpu driver for AFAR V
we compiled the 'develop' versions of clr and hip as Ben recommended. the HIP and HSA assertions
ROCP_FATAL_IF(external_corr_ids.size() < (callback_contexts.size() + buffered_contexts.size()))
that I commented out out trip with each of external_corr_ids.size(), (callback_contexts.size(), and buffered_contexts.size() == 1. omitting them, our incomplete draft of rocprofiler-sdk support in hpctoolkit is being exercised as expected.