Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop upstream sync 230814 #2193

Merged
merged 360 commits into from
Aug 22, 2023
Merged

Develop upstream sync 230814 #2193

merged 360 commits into from
Aug 22, 2023

Conversation

weihanmines
Copy link

No description provided.

AspirinSJL and others added 30 commits August 8, 2023 14:05
@AspirinSJL @tensorflower-gardener
Record num_batch_threads_ as TF does
a8286c6 
PiperOrigin-RevId: 554932893
@skye @tensorflower-gardener
Remove option to use StreamExecutor Cloud TPU client in JAX
74be7fd 
It's been over three months since the new PJRT C API client was
enabled by default
(https://jax.readthedocs.io/en/latest/changelog.html#jax-0-4-8-march-29-2023).

PiperOrigin-RevId: 554935166
@sparc1998 @tensorflower-gardener
Improve some of the documentation around sliced prefetching.
bd82663 
PiperOrigin-RevId: 554937981
@BrianWieder @tensorflower-gardener
Remove unnecessary glob in tensorflow/core:lib_internal_impl.
4c08c49 
Since all the subfolders in tensorflow/core/lib have BUILD files, no files are picked up by this glob.

PiperOrigin-RevId: 554943490
@bhavani-subramanian
Code cleanup
cd1ba12
@swachhandl @tensorflower-gardener
Reset context for a couple of python unit tests.
dd3bddb 
These tests seem to use different number of GPUs across multiple unit test cases. This causes issues with maintaining the PjRtClient and DeviceCompiler lifetimes.

PiperOrigin-RevId: 554953351
@matthew-olson-intel
Fixing build issue with Clang 16
055b714
@DrMarcII @tensorflower-gardener
Refine dtensor target_patterns.
9061817 
PiperOrigin-RevId: 554958089
@tensorflower-gardener
No public description
6da90a9 
PiperOrigin-RevId: 554958217
@cky9301 @tensorflower-gardener
Remove unused saved_model_mira_impl
7603dbd 
PiperOrigin-RevId: 554959602
@fionalang @tensorflower-gardener
Declare _PforInput parameter types.
9c62350 
PiperOrigin-RevId: 554965356
@fionalang @tensorflower-gardener
Add return type annotations related tf.constant.
f410be4 
PiperOrigin-RevId: 554967781
@matthiaskramm @tensorflower-gardener
Fix dominance issue after extract_tpu_copy_with_dynamic_shape pass.
0f772dc 
Only move TpuCopyWithDynamicShape out of launches if nothing in the
launch depends on them.

PiperOrigin-RevId: 554971170
@LionOfJewdah @tensorflower-gardener
Remove 'tensorflow/core:portable_gif_internal' dep where not needed
c302e76 
PiperOrigin-RevId: 554972724
@tensorflower-gardener
Add type annotations to AbstractGradientTape.
794ad9d 
PiperOrigin-RevId: 554973779
@yangustc07 @tensorflower-gardener
#tf-data-service Use absl::Status in distributed_snapshot_test.
12ac2e2 
PiperOrigin-RevId: 554976689
@tensorflower-gardener
[TF:PJRT] Set allowed_devices when gpu_options.visible_device_list is…
cad505d 
… not empty.

PiperOrigin-RevId: 554976987
@arcra @tensorflower-gardener
Update tensorboard dependency to >=2.14, < 2.15
063230f 
PiperOrigin-RevId: 554977992
@mpcallanan @tensorflower-gardener
#tf-data-service Reduce data transfer protocol fallback log severity …
44374f9 
…to `WARNING`.

PiperOrigin-RevId: 554982965
@DrMarcII @tensorflower-gardener
Mark all ops that are not currently exported to Python as visibility:…
4c45953 
… HIDDEN.

Add tf_export'ed raw_ops to modules_with_exports.

PiperOrigin-RevId: 554985433
@philipphack
Calculation of Amax for FP8 convolutions.
1ca3599
@DrMarcII @tensorflower-gardener
Use imported tf_export directly instead of creating an alias.
f51e72e 
PiperOrigin-RevId: 555002989
@zichuan-wei @tensorflower-gardener
lite:stablehlo: add support for converting stablehlo constants betwee…
5b90f56 
…n MLIR & Flatbuffers

PiperOrigin-RevId: 555004085
@tensorflower-gardener
Merge pull request tensorflow#61207 from Intel-tensorflow:zhoulong/en…
5b3d815 
…able_xla_auto_cluster_for_pjrt_device

PiperOrigin-RevId: 5550338
@Maratyszcza @tensorflower-gardener
Remove psimd dependency
50288fe 
- psimd was used by XNNPack, but is no longer needed

PiperOrigin-RevId: 555038715
@dansuh17 @tensorflower-gardener
Cleanup unused headers in UniformQuantizedStablehloToTflPass.
884d342 
PiperOrigin-RevId: 555043552
@SuryanarayanaY
Added test case for Changes in tf.experimental.numpy.vander
352bbf0 
Added a test case for checking the behaviour wrt numpy for the changes done in tf.experimental.numpy.vander.
@SuryanarayanaY
Resolved indentation errors in np_array_ops.py
2555ac9 
Resolved indentation error in vander function
@jreiffers @tensorflower-gardener
Make GetFusionEmitter callable before buffer assignment.
0c49fec 
For now, we just disable the in-place DUS/memcpy detection logic.

PiperOrigin-RevId: 555067189
@tensorflower-gardener
Merge pull request tensorflow#61498 from elfringham:run_build_tests
67ada06 
PiperOrigin-RevId: 555069429
@i-chaochen
Copy link

retest Ubuntu-GPU-single please

@i-chaochen
Copy link

retest Ubuntu-GPU-multi please

@weihanmines
Copy link
Author

Jenkins: retest Ubuntu-GPU-multi please

i-chaochen
i-chaochen reviewed Aug 16, 2023
View reviewed changes
Copy link

@i-chaochen i-chaochen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

memcpy for gpu.graph: https://github.com/ROCmSoftwarePlatform/frameworks-internal/issues/5458

@jayfurmanek
Copy link

retest gpu-non-pip-multi please

@weihanmines
Copy link
Author

https://github.com/orgs/ROCmSoftwarePlatform/projects/22/views/1?pane=issue&itemId=36213023

@i-chaochen
Copy link

https://github.com/orgs/ROCmSoftwarePlatform/projects/22/views/1?pane=issue&itemId=36213023

Could you at least put some descrption on this ticket and related unit tests?

@weihanmines
Copy link
Author

weihanmines commented Aug 18, 2023 •
edited
Loading

Jenkins: retest Ubuntu-GPU-single please

@weihanmines
Copy link
Author

retest Ubuntu-GPU-single please

5 similar comments
@weihanmines
Copy link
Author

retest Ubuntu-GPU-single please

@weihanmines
Copy link
Author

retest Ubuntu-GPU-single please

@weihanmines
Copy link
Author

retest Ubuntu-GPU-single please

@weihanmines
Copy link
Author

retest Ubuntu-GPU-single please

@weihanmines
Copy link
Author

retest Ubuntu-GPU-single please

i-chaochen
i-chaochen approved these changes Aug 22, 2023
View reviewed changes
Copy link

@i-chaochen i-chaochen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we have a related ticket to trace thisconv_ops_test, please? Thanks!

@weihanmines weihanmines merged commit 5fe83ee into develop-upstream Aug 22, 2023
1 check passed
@weihanmines
Copy link
Author

https://github.com/orgs/ROCmSoftwarePlatform/projects/22/views/1?pane=issue&itemId=36213023

Could you at least put some descrption on this ticket and related unit tests?

A ticket has been created. I cannot reproduce this error on my dev node though. Everything works fine on my dev node.

@i-chaochen
Copy link

https://github.com/orgs/ROCmSoftwarePlatform/projects/22/views/1?pane=issue&itemId=36213023

Could you at least put some descrption on this ticket and related unit tests?

A ticket has been created. I cannot reproduce this error on my dev node though. Everything works fine on my dev node.

This one? https://github.com/ROCmSoftwarePlatform/frameworks-internal/issues/5472

@weihanmines
Copy link
Author

https://github.com/orgs/ROCmSoftwarePlatform/projects/22/views/1?pane=issue&itemId=36213023

Could you at least put some descrption on this ticket and related unit tests?

A ticket has been created. I cannot reproduce this error on my dev node though. Everything works fine on my dev node.

This one? ROCmSoftwarePlatform/frameworks-internal#5472

https://github.com/orgs/ROCmSoftwarePlatform/projects/22/views/1?pane=issue&itemId=36568788

@weihanmines
Copy link
Author

https://github.com/orgs/ROCmSoftwarePlatform/projects/22/views/1?pane=issue&itemId=36213023

Could you at least put some descrption on this ticket and related unit tests?

A ticket has been created. I cannot reproduce this error on my dev node though. Everything works fine on my dev node.

This one? ROCmSoftwarePlatform/frameworks-internal#5472

https://github.com/orgs/ROCmSoftwarePlatform/projects/22/views/1?pane=issue&itemId=36568788#:~:text=to%20search-,frameworks%2Dinternal%20%235517,-%5BTF%5D%20The%20log

@i-chaochen
Copy link

can we have a related ticket to trace thisconv_ops_test, please? Thanks!

https://github.com/ROCmSoftwarePlatform/frameworks-internal/issues/5517

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@i-chaochen i-chaochen i-chaochen approved these changes

@jayfurmanek jayfurmanek Awaiting requested review from jayfurmanek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.