Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[develop-upstream-QA-rocm63] Update 24.04 dockerfile #2693

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,22 @@ COPY ${CUSTOM_INSTALL} /${CUSTOM_INSTALL}
COPY setup.rocm.sh /setup.rocm.sh
COPY devel.packages.rocm.txt /devel.packages.rocm.txt
COPY sles.devel.packages.rocm.txt /sles.devel.packages.rocm.txt
RUN /setup.rocm.sh $ROCM_VERSION jammy
RUN /setup.rocm.sh $ROCM_VERSION noble

# All lines past this point are reset when $CACHEBUSTER is set. We need this
# for Python specifically because we install some nightly packages which are
# likely to change daily.
ARG CACHEBUSTER=0
RUN echo $CACHEBUSTER

# Setup Python environment. PYTHON_VERSION is e.g. "python3.8"
ARG PYTHON_VERSION
COPY setup.build-python_ubuntu.sh /setup.build-python_ubuntu.sh
COPY devel.requirements.txt /devel.requirements.txt
RUN chmod +x /setup.build-python_ubuntu.sh
RUN /setup.build-python_ubuntu.sh $PYTHON_VERSION devel.requirements.txt true


# Setup ENV variables for tensorflow pip build
ENV TF_NEED_ROCM=1
ENV TF_ROCM_GCC=1
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ libssl-dev
libtool
libzmq3-dev
lld-17
mlocate
moreutils
openjdk-11-jdk
openjdk-11-jre-headless
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ libhdf5-serial-dev
libssl-dev
libtool
libzmq3-dev
mlocate
moreutils
openjdk-21-jdk
openjdk-21-jre-headless
Expand Down
6 changes: 3 additions & 3 deletions tensorflow/tools/tf_sig_build_dockerfiles/setup.rocm.sh
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,11 @@ if [[ -n $1 ]]; then
ROCM_VERSION=$1
fi
if [[ -n $2 ]]; then
if [[ "$2" == "noble" ]] || [[ "$2" == "focal" ]] || [[ "$2" == "jammy" ]] || [[ "$2" == "el7" ]] || [[ "$2" == "el8" ]]; then
if [[ "$2" == "focal" ]] || [[ "$2" == "jammy" ]] || [[ "$2" == "noble" ]] || [[ "$2" == "el7" ]] || [[ "$2" == "el8" ]]; then
DISTRO=$2
else
echo "Distro not supported"
echo "Supported distros are:\n noble\n focal\n jammy\n el7\n el8"
echo "Supported distros are:\n focal\n jammy\n noble\n el7\n el8"
exit 1
fi
fi
Expand All @@ -49,7 +49,7 @@ else
ROCM_VERS=$ROCM_VERSION
fi

if [[ "$DISTRO" == "noble" ]] || [[ "$DISTRO" == "focal" ]] || [[ "$DISTRO" == "jammy" ]]; then
if [[ "$DISTRO" == "focal" ]] || [[ "$DISTRO" == "jammy" ]] || [[ "$DISTRO" == "noble" ]]; then
ROCM_DEB_REPO_HOME=https://repo.radeon.com/rocm/apt/
AMDGPU_DEB_REPO_HOME=https://repo.radeon.com/amdgpu/
ROCM_BUILD_NAME=${DISTRO}
Expand Down
Loading