Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport BF16 Support to Necessary Ops #2723

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Backport BF16 Support to Necessary Ops #2723

merged 1 commit into from
Oct 22, 2024

Conversation

ScXfjiang
Copy link

@ScXfjiang ScXfjiang commented Oct 21, 2024 •
edited
Loading

@ScXfjiang ScXfjiang marked this pull request as ready for review October 21, 2024 16:00
@i-chaochen
Copy link

i-chaochen commented Oct 21, 2024 •
edited
Loading

Thanks! @ScXfjiang could sqush as one commit and list all added bf16 supports in this one commit message, please?

i-chaochen
i-chaochen approved these changes Oct 21, 2024
View reviewed changes
Copy link

@i-chaochen i-chaochen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

tensorflow/python/BUILD Outdated Show resolved Hide resolved
@ScXfjiang
Copy link
Author

Thanks! @ScXfjiang could sqush as one commit and list all added bf16 supports in this one commit message, please?

done

@ScXfjiang ScXfjiang merged commit 1cb22a1 into r2.13-rocm-enhanced-upate-llvm Oct 22, 2024
2 checks passed
@ScXfjiang ScXfjiang deleted the dev_r213_bf16_op_support branch October 22, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@i-chaochen i-chaochen i-chaochen approved these changes

@pemeliya pemeliya pemeliya approved these changes

@jayfurmanek jayfurmanek Awaiting requested review from jayfurmanek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ScXfjiang @i-chaochen @pemeliya