fix: replace if/else statement with tl.where #545
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While running the flash attention benchmark in a python environment, I encountered the following error
is_mqa = hq != hk
off_h_k = off_h_q % hk if is_mqa else off_h_q
^
Triton does not support if expressions (ternary operators) with dynamic conditions, use
ifstatements instead
Version information
ROCm: 5.7.3
python: 3.11
Triton: pytorch-triton-rocm: 2.2.0
System: MI250 (gfx90a)
Solution: Replaced the if/else statement with tl.where function. With this replacement, the benchmark runs without error message.