Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting quantized weights from Quark by default. #47

Merged
merged 9 commits into from
Jun 13, 2024

Conversation

charlifu
Copy link

This PR adds Quark support to accept its quantized weights as our input.

By default, vllm fp8 accepts the output form Quark. If users still want to use ammo as the fp8 input, set VLLM_FP8_USE_AMMO=1.

@charlifu charlifu requested a review from shajrawi June 13, 2024 16:08
Copy link
Collaborator

@shajrawi shajrawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make the linter/CI happy - other than that looks good.

@charlifu charlifu requested a review from shajrawi June 13, 2024 16:28
Copy link
Collaborator

@shajrawi shajrawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

@charlifu charlifu merged commit dc60612 into main Jun 13, 2024
13 checks passed
@charlifu charlifu deleted the charlifu/quark_support branch June 13, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants