[ROCm] Fixed linker issues with rocblas_get_version_string_size and r…

…ocblas_get_version_string
ROCm · Oct 14, 2024 · c320e9c · c320e9c
1 parent cfc4c64
commit c320e9c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/xla/stream_executor/rocm/rocblas_wrapper.h b/xla/stream_executor/rocm/rocblas_wrapper.h
@@ -275,7 +275,9 @@ using stream_executor::internal::CachedDsoLoader::GetRocblasDsoHandle;
   __macro(rocblas_destroy_handle)                        \
   __macro(rocblas_get_stream)                            \
   __macro(rocblas_set_stream)                            \
-  __macro(rocblas_set_atomics_mode)
+  __macro(rocblas_set_atomics_mode)                      \
+  __macro(rocblas_get_version_string_size)               \
+  __macro(rocblas_get_version_string)
 
 // clang-format on
 

diff --git a/xla/stream_executor/rocm/rocm_blas.cc b/xla/stream_executor/rocm/rocm_blas.cc
@@ -1234,7 +1234,6 @@ IMPL_DoBlasGemmBatched(float, wrap::rocblas_sgemm_strided_batched)
 }
 
 absl::Status ROCMBlas::GetVersion(std::string *version) {
-#if TF_ROCM_VERSION >= 60200  // Not available in ROCM-6.1
   absl::MutexLock lock{&mu_};
   size_t len = 0;
   if (auto res = wrap::rocblas_get_version_string_size(&len);
@@ -1250,9 +1249,6 @@ absl::Status ROCMBlas::GetVersion(std::string *version) {
   }
   *version = std::string(buf.begin(), buf.end());
   return absl::OkStatus();
-#else
-  return absl::UnimplementedError("");
-#endif
 }
 
 }  // namespace gpu