Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added more 8ball commands. #419

Merged
merged 4 commits into from
Oct 4, 2019
Merged

Added more 8ball commands. #419

merged 4 commits into from
Oct 4, 2019

Conversation

cgunston
Copy link
Contributor

@cgunston cgunston commented Oct 4, 2019

For #117

@cgunston cgunston mentioned this pull request Oct 4, 2019
Open
13xforever
13xforever suggested changes Oct 4, 2019
View reviewed changes
Copy link
Contributor

@13xforever 13xforever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please try to maintain positive-to-neutral-to-negative balance of 3:2:3, keep slight variations to a minimum, and update response counters in the comments to make the ratio tracking easier

CompatBot/Commands/Misc.cs Outdated Show resolved Hide resolved
CompatBot/Commands/Misc.cs Outdated Show resolved Hide resolved
cgunston and others added 2 commits October 4, 2019 12:22
@cgunston @13xforever
Update CompatBot/Commands/Misc.cs
3cc5e87 
Co-Authored-By: Ilya <36445+13xforever@users.noreply.github.com>
@cgunston @13xforever
Update CompatBot/Commands/Misc.cs
363f68e 
Co-Authored-By: Ilya <36445+13xforever@users.noreply.github.com>
@cgunston
Copy link
Contributor Author

cgunston commented Oct 4, 2019

Hi 13xforever

Thanks for the comments, I'm still just getting started at the moment.

I've resolved my commits based on your comments. Does that seem ok now?

Thanks!

@13xforever 13xforever self-assigned this Oct 4, 2019
@13xforever 13xforever added the fun stuff things to entertain the crowds label Oct 4, 2019
@13xforever 13xforever added this to the v2.14 milestone Oct 4, 2019
@13xforever
Copy link
Contributor

@cgunston can you squash everything to one commit? I'd prefer this to be an atomic change, and I don't want to use autosquash on github as it will change the author

@cgunston
Copy link
Contributor Author

cgunston commented Oct 4, 2019

@13xforever Apologies what would be the best way to achieve that?

@13xforever
Copy link
Contributor

if you don't know then it's ok, I'll just merge as is

@13xforever 13xforever merged commit 8661bfe into RPCS3:master Oct 4, 2019
@cgunston
Copy link
Contributor Author

cgunston commented Oct 4, 2019

@13xforever Thank you! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@13xforever 13xforever 13xforever approved these changes

Assignees

@13xforever 13xforever

Labels
fun stuff things to entertain the crowds
Projects
None yet
Milestone
v2.14
Development

Successfully merging this pull request may close these issues.
2 participants
@cgunston @13xforever