More SPU patterns #15211
Draft
More SPU patterns #15211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
RipleyTom
commented
Feb 15, 2024
RipleyTom
commented
- Simplified re_accurate pattern and fixed an edge case in the intrinsic
- Fixed and simplified sqrt pattern(still need to test accuracy)
- Added an alternative re_accurate pattern used by GOW3 that should give the same result
RipleyTom
force-pushed
the
more_spu_stuff
branch
from
701f84f
to
acf1521
Compare
elad335
reviewed
Feb 15, 2024
|
This PR breaks NFS Most Wanted audio on Approximate XFloat. This doesnt happen on the latest build. |
RipleyTom
force-pushed
the
more_spu_stuff
branch
from
acf1521
to
ef5cffd
Compare
elad335
reviewed
Feb 17, 2024
| const auto bitcast_float = bitcast<u32[4]>(cursed_float); | ||
| set_vr(op.rt4, select(bitcast_float == splat<u32[4]>(0x3F800000) | bitcast_float == splat<u32[4]>(0x3F800001), fsqrt(fabs(x)), fma(fnms(spu_rsqrte(x), c, cursed_float), fm(fsplat<f32[4]>(0.5f), fm(x, spu_rsqrte(x))), fm(x, spu_rsqrte(x))))); | ||
| const auto bitcast_float = bitcast<u32[4]>(fnms_float); | ||
| set_vr(op.rt4, select(fcmp_uno(fm_float == fsplat<f32[4]>(0.5f)) & (bitcast_float == splat<u32[4]>(0x3F800000) | bitcast_float == splat<u32[4]>(0x3F800001)), fsqrt(fabs(x)), fma(fnms(spu_rsqrte(x), c, fnms_float), fm(fm_float, fm(x, spu_rsqrte(x))), fm(x, spu_rsqrte(x))))); |
There was a problem hiding this comment.
select evaluates all its arguments, its why it exists (so it would be branch-less)
So this would perform worse.
You can use conditional jumps
|
@RipleyTom is there a reason why this PR is still in draft and not yet merged? Is there something that we can test to allow the PR is merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.