Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add empty f0 file check to Pipeline.pipeline #2341

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

limitcantcode
Copy link

Pull request checklist

  • The PR has a proper title. Use Semantic Commit Messages. (No more branch-name title please)

  • Make sure this is ready to be merged into the relevant branch. Please don't create a PR and let it hang for a few days.

  • Ensure you can run the codes you submitted succesfully. These submissions will be prioritized for review:

    Introduce improvements in program execution speed;

    Introduce improvements in synthesis quality;

    Fix existing bugs reported by user feedback (or you met);

    Introduce more convenient user operations.

PR type

  • Bug fix / feature change

Description

  • In inference UI, f0 file field is not shown and None is given to API by default. It is also described as optional in AP>
  • Using gradio_client to access infer_convert does not allow use of None or empty strings for f0_file.
  • Pipeline.pipeline will fault out if the given an empty file for f0 file.
  • Added checks when first processing f0_file in Pipeline.pipeline to keep inp_f0 as None on empty files as intended.

Screenshot

  • Please include a screenshot if applicable

- Added checks for empty f0_file, skipping faulty inp_f0 creation if empty as it should
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant