feat: add bounded local capacity telemetry - #73
Conversation
|
@codex review Focused exact-head review at 1b5430d. Verify sampling activation, resource-only/redacted schema, local-only behavior, file trust boundary, retention bounds, per-pool and anonymous runner aggregation, nearest-rank p50/p95 report, failure behavior, uninstall cleanup, and tests. The external private-config planning PR remains explicitly out of scope. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1b5430d072
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review Focused exact-head confirmation at d3ab11b. Verify the six accepted telemetry root causes: 30-second/event-representative sampling, interval CPU, atomic schema validation, idle retention pruning, fail-closed Docker stats, and protected history paths. Also review legacy-engine compatibility and installer rollback. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d3ab11b15d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e76754a3e3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4a6876496b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review [lane-b:pr73:review:60b64ee6] Please perform an exact-head review of 60b64ee, including the accepted legacy-downgrade service-stop root cause, timer/service ordering, installer regression, rollback/idempotence, and the complete capacity telemetry contract. The private desired-state acceptance item remains outside authorization. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 60b64ee6cc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review [lane-b:pr73:review:3df6cb4] Exact-head review requested for 3df6cb4. Verify all five accepted root causes: legacy-to-current round-trip with a forward-compatible manager and runtime-owned units, fail-closed service stop/rollback, dangling history symlink rejection, capability-to-artifact enforcement, and read-only report bytecode behavior. Full mocked installer lifecycle and focused validation pass. The private desired-state acceptance item remains outside authorization. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3df6cb4d48
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review [lane-b:pr73:review:71f56fb] Please confirm exact head 71f56fb after the accepted rollback stop-propagation fix. Verify that a failed capacity-service stop returns before unit deletion in candidate downgrade, uninstall, and rollback set +e contexts, and that the existing telemetry lifecycle guarantees remain intact. |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Implements the repository-owned portion of #50.
Validation:
python3 scripts/test_health.pypython3 scripts/test_desired_state.pyscripts/test-install-worker-controller.shDraft/external gate: the required reviewed capacity-planning PR in the private
rd-delivery-configrepository is outside this marathon authorization. This PR does not create or mutate that external configuration and must remain unmerged until that acceptance evidence is available.