Enable Pyodide input test #1125
Open
+363
−161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er is initialised
sra405
temporarily deployed
to
previews/1125/merge
GitHub Actions
Inactive
sra405
temporarily deployed
to
previews/1125/merge
GitHub Actions
Inactive
sra405
temporarily deployed
to
previews/1125/merge
GitHub Actions
Inactive
sra405
temporarily deployed
to
previews/1125/merge
GitHub Actions
Inactive
sra405
force-pushed
the
enable-pyodide-input-test
branch
from
dd7eea2
to
263cc73
Compare
sra405
temporarily deployed
to
previews/1125/merge
GitHub Actions
Inactive
sra405
temporarily deployed
to
previews/1125/merge
GitHub Actions
Inactive
sra405
temporarily deployed
to
previews/1125/merge
GitHub Actions
Inactive
sra405
temporarily deployed
to
previews/1125/merge
GitHub Actions
Inactive
sra405
temporarily deployed
to
previews/1125/merge
GitHub Actions
Inactive
sra405
temporarily deployed
to
previews/1125/merge
GitHub Actions
Inactive
sra405
temporarily deployed
to
previews/1125/merge
GitHub Actions
Inactive
sra405
temporarily deployed
to
previews/1125/merge
GitHub Actions
Inactive
sra405
temporarily deployed
to
previews/1125/merge
GitHub Actions
Inactive
sra405
temporarily deployed
to
previews/1125/merge
GitHub Actions
Inactive
sra405
temporarily deployed
to
previews/1125/merge
GitHub Actions
Inactive
sra405
temporarily deployed
to
previews/1125/merge
GitHub Actions
Inactive
sra405
temporarily deployed
to
previews/1125/merge
GitHub Actions
Inactive
sra405
temporarily deployed
to
previews/1125/merge
GitHub Actions
Inactive
conorriches
reviewed
Oct 29, 2024
src/components/Editor/Runners/PythonRunner/PyodideRunner/PyodideRunner.jsx
Show resolved
Hide resolved
conorriches
reviewed
Oct 29, 2024
| useEffect(() => { | ||
| if (active) { | ||
| if (codeRunTriggered) { | ||
| console.log("running with skulpt"); |
danhalson
reviewed
Oct 29, 2024
| const codeRunTriggered = useSelector( | ||
| (state) => state.editor.codeRunTriggered, | ||
| ); | ||
| const senseHatAlwaysEnabled = useSelector( | ||
| (state) => state.editor.senseHatAlwaysEnabled, | ||
| ); | ||
| const [usePyodide, setUsePyodide] = useState(true); | ||
| const [usePyodide, setUsePyodide] = useState(null); | ||
| const [skupltFallback, setSkulptFallback] = useState(false); |
There was a problem hiding this comment.
looks like it's used consistently, but there's a typo here thats makes the code hard to read, skupltFallback is probably meant to be skulptFallback
danhalson
reviewed
Oct 29, 2024
| if (browser.name === "chrome") { | ||
| console.log("Applying Chrome launch options"); | ||
| launchOptions.args.push("--enable-features=SharedArrayBuffer"); | ||
| launchOptions.args.push("--disable-site-isolation-trials"); |
There was a problem hiding this comment.
wow google, if it's a trial, why not have it opt-in??
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/RaspberryPiFoundation/digital-editor-issues/issues/327
Changes where also ensure the pyodide execution in Cypress is closer aligned to how it's used