-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Notification for Tutors (fixes #14) #20
Conversation
(#14) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will only work if the student joins via the /queue join command. Please also edit the voiceStateUpdateEvent.ts File to cover the voice channel join method.
Also i think it would help if the Tutors get notified when every student leaves and the queue is empty. Maybe a designated guild channel with restricted access for queue events would be a better option instead of notifying every active tutor individually, what do you think? Then we could also have a pinned message there that auto-updates whenever someone joins/leaves the queue.
I think the idea with DMs is not that bad. This way a tutor only gets notified when they have an active session. |
Should create new role for currently active tutors. Create notifications for tutors with active role in a separate channel. This means notifications when someone new joins the queue |
1f747bb
to
f9502ef
Compare
3cf5f38
to
8c146f6
Compare
The /setqueueinfo command can be used to bind a text channel to a queue as a queue info channel. This text channel then informs all users with the role active_session about users joining the queue |
Oops, c2301d5 wasn't just linting, i also changed the role resolution to use the saved role ids instead of by name, as this would not work with custom role names. |
f1410ca
to
358a05b
Compare
I have added a new service layer to manage the bot's business logic. In future, I think it would be logical to remove the actual logic from the commands and control it in the services classes in the service folder. This gives the project a better modularity and structure. The example of the QueueInfoService clearly shows the layer division. What do you think of this approach? Now to the new functionality: The /queueinfo remove channel queue |
f66fd32
to
2edee7a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small fixes still needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.