-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix-rand-matrixDirichlet #211
Conversation
@Raphael-Tresor can you add test cases that test this behaviour? |
Sure!
…On Thu, Sep 26, 2024, 4:06 PM Wouter Nuijten ***@***.***> wrote:
@Raphael-Tresor <https://github.com/Raphael-Tresor> can you add test
cases that test this behaviour?
—
Reply to this email directly, view it on GitHub
<#211 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJUMXNAPRRHVS2N6VOGOAH3ZYQIFRAVCNFSM6AAAAABO5DI4J2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZXGA3TOMRTGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Will do it tomorrow mornig
On Thu, Sep 26, 2024, 5:06 PM Raphael Tresor ***@***.***>
wrote:
… Sure!
On Thu, Sep 26, 2024, 4:06 PM Wouter Nuijten ***@***.***>
wrote:
> @Raphael-Tresor <https://github.com/Raphael-Tresor> can you add test
> cases that test this behaviour?
>
> —
> Reply to this email directly, view it on GitHub
> <#211 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AJUMXNAPRRHVS2N6VOGOAH3ZYQIFRAVCNFSM6AAAAABO5DI4J2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZXGA3TOMRTGU>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
|
Thanks @Raphael-Tresor!! indeed a test is necessary to ensure the bug will not occur again in the future. |
I added tests @wouterwln |
For some reason |
Fix bug
Previous was working only for squared matrix.
Now iterate over the number of columns to generate Dirichlet data.