fix-rand-matrixDirichlet

[Raphael-Tresor]

Fix bug

Previous was working only for squared matrix.
Now iterate over the number of columns to generate Dirichlet data.

[wouterwln]

@Raphael-Tresor can you add test cases that test this behaviour?

[Raphael-Tresor]

Sure!

…

On Thu, Sep 26, 2024, 4:06 PM Wouter Nuijten ***@***.***> wrote: @Raphael-Tresor <https://github.com/Raphael-Tresor> can you add test cases that test this behaviour? — Reply to this email directly, view it on GitHub <#211 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AJUMXNAPRRHVS2N6VOGOAH3ZYQIFRAVCNFSM6AAAAABO5DI4J2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZXGA3TOMRTGU> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[Raphael-Tresor]

Will do it tomorrow mornig On Thu, Sep 26, 2024, 5:06 PM Raphael Tresor ***@***.***> wrote:

…

Sure! On Thu, Sep 26, 2024, 4:06 PM Wouter Nuijten ***@***.***> wrote: > @Raphael-Tresor <https://github.com/Raphael-Tresor> can you add test > cases that test this behaviour? > > — > Reply to this email directly, view it on GitHub > <#211 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AJUMXNAPRRHVS2N6VOGOAH3ZYQIFRAVCNFSM6AAAAABO5DI4J2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZXGA3TOMRTGU> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> >

[bvdmitri]

Thanks @Raphael-Tresor!! indeed a test is necessary to ensure the bug will not occur again in the future.

[Raphael-Tresor]

I added tests @wouterwln

[wouterwln]

For some reason rand! was allocating a matrix of samples and then copying this one by one to the desired container. Also, it used rand for Dirichlet, where rand! can also be used. I renewed the implementation. The runtime is similar but the amount of allocations went from $\mathcal{O}(n)$ to 2.