Fix bug on isproper of MatrixDirichlet
#215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wouterwln
reviewed
Oct 23, 2024
| @@ -90,15 +90,14 @@ end | |||
| end | |||
|
|
|||
| for space in (MeanParametersSpace(), NaturalParametersSpace()) | |||
| @test !isproper(space, MatrixDirichlet, [Inf Inf; Inf 1.0], 1.0) | |||
| @test !isproper(space, MatrixDirichlet, [Inf Inf; Inf 1.0]) | |||
There was a problem hiding this comment.
Why are you changing this test? Just to see if the nothing condition hits?
There was a problem hiding this comment.
If I am not wrong, the noting condition will always hit if we add a fourth argument in the function call. So almost all the tests used to check only that. Right?
wouterwln
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isproperfunction was to test the absence of the last argument in the call and most of the test had a last argumentisproperitself had an assertion that was always true independently of the input of MatrixDirichletclose #213