Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add manifold for Categorical distribution #15

Merged
merged 17 commits into from
Jul 25, 2024
Merged

Conversation

ismailsenoz
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.59%. Comparing base (8dedefe) to head (99b234b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #15      +/-   ##
==========================================
+ Coverage   96.09%   96.59%   +0.49%     
==========================================
  Files          22       24       +2     
  Lines         282      323      +41     
==========================================
+ Hits          271      312      +41     
  Misses         11       11              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@bvdmitri bvdmitri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @Nimrais & @ismailsenoz ! LGTM, but the CI is failing....

src/SinglePointManifold.jl Outdated Show resolved Hide resolved
src/ExponentialFamilyManifolds.jl Outdated Show resolved Hide resolved
@Nimrais
Copy link
Member

Nimrais commented Jul 23, 2024

Great work @Nimrais & @ismailsenoz ! LGTM, but the CI is failing....

Yeah, I found a bug in my implementation of the SinglePointManifold.jl while playing with projections, I will fix it and I will ping you.

@Nimrais
Copy link
Member

Nimrais commented Jul 23, 2024

Yeah to really make this manifold useful, we need to first have this fixed ReactiveBayes/ExponentialFamily.jl#202. Because kinda the most crucial thing of this package ability to cast a point on manifold into distribution does not work.

@bvdmitri
Copy link
Member

bvdmitri commented Jul 25, 2024

@Nimrais the fix for ReactiveBayes/ExponentialFamily.jl#202 has been released

@Nimrais
Copy link
Member

Nimrais commented Jul 25, 2024

@Nimrais the fix for ReactiveBayes/ExponentialFamily.jl#202 has been released

Thanks I will finish the PR then

@Nimrais Nimrais requested a review from bvdmitri July 25, 2024 12:40
Copy link
Member

@bvdmitri bvdmitri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bvdmitri bvdmitri merged commit 61ce1a7 into main Jul 25, 2024
3 of 4 checks passed
@bvdmitri bvdmitri deleted the categorical_manifold branch July 25, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants