Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add InverseGamma natural manifold #18

Merged
merged 4 commits into from
Aug 20, 2024

Conversation

Nimrais
Copy link
Member

@Nimrais Nimrais commented Aug 12, 2024

This PR adds InverseGamma natural manifold

@Nimrais Nimrais requested a review from albertpod August 12, 2024 14:10
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.63%. Comparing base (5960f56) to head (a2c6ded).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #18      +/-   ##
==========================================
+ Coverage   96.59%   96.63%   +0.04%     
==========================================
  Files          24       25       +1     
  Lines         323      327       +4     
==========================================
+ Hits          312      316       +4     
  Misses         11       11              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@bvdmitri bvdmitri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, but its a bit weird that we need to prepend it with ExponentialFamily, since

julia> using ExponentialFamily

julia> using Distributions

julia> ExponentialFamily.InverseGamma === Distributions.InverseGamma
true

julia> ExponentialFamily.GammaInverse === Distributions.InverseGamma
true

@Nimrais
Copy link
Member Author

Nimrais commented Aug 13, 2024

Looks fine to me, but its a bit weird that we need to prepend it with ExponentialFamily, since

julia> using ExponentialFamily

julia> using Distributions

julia> ExponentialFamily.InverseGamma === Distributions.InverseGamma
true

julia> ExponentialFamily.GammaInverse === Distributions.InverseGamma
true

Yeah, it's true. However it's because we do not have Distributions.jl in our dependencies and ExponentialFamily does not export InverseGamma or GammaInverse.

@Nimrais Nimrais merged commit 414586e into main Aug 20, 2024
4 checks passed
@Nimrais Nimrais deleted the Inverse-Gamma-Natural-Manifold branch August 20, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants