Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to FastCholesky.jl #354

Merged
merged 2 commits into from
Oct 9, 2023
Merged

Switch to FastCholesky.jl #354

merged 2 commits into from
Oct 9, 2023

Conversation

bvdmitri
Copy link
Member

@bvdmitri bvdmitri commented Oct 9, 2023

This PR removes the cholesky folder and uses FastCholesky instead

Copy link
Member

@bartvanerp bartvanerp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simplified distributions/wishart_inverse.jl slightly. If tests pass, feel free to merge.

@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (fcfc9c1) 67.24% compared to head (5879d6b) 67.33%.
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #354      +/-   ##
==========================================
+ Coverage   67.24%   67.33%   +0.09%     
==========================================
  Files         209      208       -1     
  Lines        7699     7654      -45     
==========================================
- Hits         5177     5154      -23     
+ Misses       2522     2500      -22     
Files Coverage Δ
src/ReactiveMP.jl 63.15% <ø> (ø)
src/distributions/wishart_inverse.jl 84.84% <100.00%> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bvdmitri bvdmitri merged commit da2c4c6 into master Oct 9, 2023
12 checks passed
@bvdmitri bvdmitri deleted the dev-fast-cholesky branch October 9, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants