Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Obfuscate email and phone in profileDiff response #2205

Merged
merged 3 commits into from
Oct 8, 2024

Conversation

lakshayman
Copy link
Contributor

Date: 08 Oct 2024

Developer Name: @lakshayman


Issue Ticket Number

#2204

Description

This PR addresses an issue where the email and phone fields were not being obfuscated in the profileDiff response. It adds checks to obfuscate the email and phone fields before sending the response back to the client. This ensures that sensitive user data is protected.

Documentation Updated?

  • Yes
  • No

No documentation updates were needed as this was an internal bug fix related to obfuscation.

Under Feature Flag

  • Yes
  • No

This fix is applied globally and is not gated by a feature flag.

Database Changes

  • Yes
  • No

No database changes were required for this fix.

Breaking Changes

  • Yes
  • No

There are no breaking changes associated with this update.

Development Tested?

  • Yes
  • No

This fix has been tested locally.

image

@lakshayman lakshayman self-assigned this Oct 8, 2024
@lakshayman lakshayman marked this pull request as draft October 8, 2024 08:07
@lakshayman lakshayman marked this pull request as ready for review October 8, 2024 08:31
@iamitprakash iamitprakash merged commit cd84557 into develop Oct 8, 2024
3 checks passed
@iamitprakash iamitprakash deleted the fix/obfuscate-email-phone-profileDiff branch October 8, 2024 10:27
@lakshayman lakshayman mentioned this pull request Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants