Corrected loading issue and extra space in standup submit #1230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
iamitprakash
approved these changes
Aug 9, 2024
Achintya-Chatterjee
added a commit
that referenced
this pull request
Aug 21, 2024
* fix: assign text box alignment it would be be appearing where the name is * feat: Update TaskDetails component and fix test for assignee input - Updated TaskDetails component to include assignee input with a data-testid of 'assignee-input'. - Modified the test for rendering the assignee dropdown to correctly identify the assignee input field using the updated test ID. - Ensured the test checks for the presence of the assignee input field in edit mode. * refactor: make the superuser to false on test files * refactor: Reintroduce getExtensionRequestLink function to TaskDetails component - Added back the getExtensionRequestLink function to handle the extension request URL generation. - Updated the assignee handling in the render method to include suggestions for editing. - Maintained the isEditing and isUserAuthorized checks for showing the assignee input field. - Ensured the task extension request link is correctly generated and displayed in the Dates section. * fix: Resolve duplicate input field and suggestion box issues in TaskDetails - Fixed issue with duplicate input fields appearing in the Assignee section. - Ensured the suggestion box appears correctly below the Assignee input field. - Applied consistent styling to the Assignee input field and suggestion box. - Linked the label to the input field using the attribute. - Refactored the Assignee input and suggestion box to use the Suggestions component properly. * fix: classname to be more generic * refactor: test cases to use those old values * fix: Ensure consistent width for suggestion box and refactor styles - Updated suggestion box styles to maintain a consistent width relative to the input field - Ensured suggestion box width is set to 100% of its parent container - Adjusted styles for better visual consistency * Fix: Assignee text box alignment (#1225) * fix: assign text box alignment it would be be appearing where the name is * feat: Update TaskDetails component and fix test for assignee input - Updated TaskDetails component to include assignee input with a data-testid of 'assignee-input'. - Modified the test for rendering the assignee dropdown to correctly identify the assignee input field using the updated test ID. - Ensured the test checks for the presence of the assignee input field in edit mode. * refactor: make the superuser to false on test files * refactor: Reintroduce getExtensionRequestLink function to TaskDetails component - Added back the getExtensionRequestLink function to handle the extension request URL generation. - Updated the assignee handling in the render method to include suggestions for editing. - Maintained the isEditing and isUserAuthorized checks for showing the assignee input field. - Ensured the task extension request link is correctly generated and displayed in the Dates section. * fix: Resolve duplicate input field and suggestion box issues in TaskDetails - Fixed issue with duplicate input fields appearing in the Assignee section. - Ensured the suggestion box appears correctly below the Assignee input field. - Applied consistent styling to the Assignee input field and suggestion box. - Linked the label to the input field using the attribute. - Refactored the Assignee input and suggestion box to use the Suggestions component properly. * fix: classname to be more generic * refactor: test cases to use those old values * fix: Ensure consistent width for suggestion box and refactor styles - Updated suggestion box styles to maintain a consistent width relative to the input field - Ensured suggestion box width is set to 100% of its parent container - Adjusted styles for better visual consistency * Corrected loading issue and extra space in standup submit (#1230) Co-authored-by: Shubham Sharma <shbh541@gmail.com> * fix: prevent Status field from being displayed twice in TaskDetails component Refactored TaskDetails component to conditionally render either the TaskDropDown for editing or the Details component for viewing the status, ensuring the Status field is only displayed once depending on the editing state. * fix: prevent Status field from being displayed twice in TaskDetails component Refactored TaskDetails component to conditionally render either the TaskDropDown for editing or the Details component for viewing the status, ensuring the Status field is only displayed once depending on the editing state. * Fix: Assignee text box alignment (#1225) (#1228) (#1234) * Refactor else condition (#1240) * Corrected loading issue and extra space in standup submit * Fixed early return --------- Co-authored-by: Shubham Sharma <shbh541@gmail.com> --------- Co-authored-by: Amit Prakash <34869115+iamitprakash@users.noreply.github.com> Co-authored-by: Shubham Sharma <68867418+skv93-coder@users.noreply.github.com> Co-authored-by: Shubham Sharma <shbh541@gmail.com>
iamitprakash
added a commit
that referenced
this pull request
Sep 3, 2024
* fix: assign text box alignment it would be be appearing where the name is * feat: Update TaskDetails component and fix test for assignee input - Updated TaskDetails component to include assignee input with a data-testid of 'assignee-input'. - Modified the test for rendering the assignee dropdown to correctly identify the assignee input field using the updated test ID. - Ensured the test checks for the presence of the assignee input field in edit mode. * refactor: make the superuser to false on test files * refactor: Reintroduce getExtensionRequestLink function to TaskDetails component - Added back the getExtensionRequestLink function to handle the extension request URL generation. - Updated the assignee handling in the render method to include suggestions for editing. - Maintained the isEditing and isUserAuthorized checks for showing the assignee input field. - Ensured the task extension request link is correctly generated and displayed in the Dates section. * fix: Resolve duplicate input field and suggestion box issues in TaskDetails - Fixed issue with duplicate input fields appearing in the Assignee section. - Ensured the suggestion box appears correctly below the Assignee input field. - Applied consistent styling to the Assignee input field and suggestion box. - Linked the label to the input field using the attribute. - Refactored the Assignee input and suggestion box to use the Suggestions component properly. * fix: classname to be more generic * refactor: test cases to use those old values * fix: Ensure consistent width for suggestion box and refactor styles - Updated suggestion box styles to maintain a consistent width relative to the input field - Ensured suggestion box width is set to 100% of its parent container - Adjusted styles for better visual consistency * Fix: Assignee text box alignment (#1225) * fix: assign text box alignment it would be be appearing where the name is * feat: Update TaskDetails component and fix test for assignee input - Updated TaskDetails component to include assignee input with a data-testid of 'assignee-input'. - Modified the test for rendering the assignee dropdown to correctly identify the assignee input field using the updated test ID. - Ensured the test checks for the presence of the assignee input field in edit mode. * refactor: make the superuser to false on test files * refactor: Reintroduce getExtensionRequestLink function to TaskDetails component - Added back the getExtensionRequestLink function to handle the extension request URL generation. - Updated the assignee handling in the render method to include suggestions for editing. - Maintained the isEditing and isUserAuthorized checks for showing the assignee input field. - Ensured the task extension request link is correctly generated and displayed in the Dates section. * fix: Resolve duplicate input field and suggestion box issues in TaskDetails - Fixed issue with duplicate input fields appearing in the Assignee section. - Ensured the suggestion box appears correctly below the Assignee input field. - Applied consistent styling to the Assignee input field and suggestion box. - Linked the label to the input field using the attribute. - Refactored the Assignee input and suggestion box to use the Suggestions component properly. * fix: classname to be more generic * refactor: test cases to use those old values * fix: Ensure consistent width for suggestion box and refactor styles - Updated suggestion box styles to maintain a consistent width relative to the input field - Ensured suggestion box width is set to 100% of its parent container - Adjusted styles for better visual consistency * Corrected loading issue and extra space in standup submit (#1230) * fix: prevent Status field from being displayed twice in TaskDetails component Refactored TaskDetails component to conditionally render either the TaskDropDown for editing or the Details component for viewing the status, ensuring the Status field is only displayed once depending on the editing state. * fix: prevent Status field from being displayed twice in TaskDetails component Refactored TaskDetails component to conditionally render either the TaskDropDown for editing or the Details component for viewing the status, ensuring the Status field is only displayed once depending on the editing state. * Fix: Assignee text box alignment (#1225) (#1228) (#1234) * Refactor else condition (#1240) * Corrected loading issue and extra space in standup submit * Fixed early return --------- --------- Co-authored-by: Amit Prakash <34869115+iamitprakash@users.noreply.github.com> Co-authored-by: Shubham Sharma <68867418+skv93-coder@users.noreply.github.com> Co-authored-by: Shubham Sharma <shbh541@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Date: 9 Aug 24
Developer Name: @skv93-coder
Issue Ticket Number
#1218
Description
Disabled the button for submission of standup until standup is submitted and remove spaces while submitting.
Documentation Updated?
Under Feature Flag
Database Changes
Breaking Changes
Development Tested?
Screenshots
Screenshot 1
screen-capture.3.webm
Test Coverage
Screenshot 1
Additional Notes