Fixing review comments

RedHatQE · Sep 19, 2024 · 4629f37 · 4629f37
1 parent 2d7e186
commit 4629f37
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 9 deletions.
diff --git a/cloudwash/entities/resources/containers.py b/cloudwash/entities/resources/containers.py
@@ -45,17 +45,16 @@ class CleanPodmanContainers(CleanContainers):
     def list(self):
 
         for container in self.client.containers:
-            container_name = container.name
-            if container_name in settings.podman.exceptions.container.skip_list:
-                self._skip.append(container_name)
+            if container.name in settings.podman.exceptions.container.skip_list:
+                self._skip.append(container.name)
                 continue
             elif total_running_time(container).minutes >= settings.podman.criteria.container.sla:
 
-                if container_name in settings.podman.exceptions.container.stop_list:
-                    self._stop.append(container_name)
+                if container.name in settings.podman.exceptions.container.stop_list:
+                    self._stop.append(container.name)
                     continue
 
-                elif container_name.startswith(settings.podman.criteria.container.name_prepend):
-                    self._delete.append(container_name)
+                elif container.name.startswith(settings.podman.criteria.container.name_prefix):
+                    self._delete.append(container.name)
 
         self._set_dry()
diff --git a/settings.yaml.template b/settings.yaml.template
@@ -117,12 +117,12 @@ PODMAN:
     CRITERIA:
         CONTAINER:
             # Container Prepended Test
-            NAME_PREPEND: 'satci'
+            NAME_PREFIX: 'satci'
             # Container running time in minutes
             SLA: 720
     EXCEPTIONS:
         CONTAINER:
             # Containers to skip and not to delete
             SKIP_LIST: []
-            # Contsiners to stop if running but not delete
+            # Containers to stop if running but not delete
             STOP_LIST: []