Change compiled executable names to match the new project name #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
co-bby
approved these changes
Oct 1, 2024
filipworksdev
approved these changes
Oct 2, 2024
|
Looks like some Checks failed. I'll fire up my mac m1 and Linux box up later tonight and fix whatever is causing the build failure. I should have checked before making a PR, apologies. |
|
I think the issue is some scripts are looking for the executable godot but is not finding it because redot is exported instead |
|
Aye, I found that the check scripts are in .github/workflows. I should have a patch committed tonight. They've been very informative so far, and I think it's going to help us weed out additional branding edge cases in the future. |
Starkium
reviewed
Oct 6, 2024
|
I'll rebase tonight and submit, thanks for the heads up. |
Tekisasu-JohnK
deleted the
Change-compiled-executable-names-to-match-the-new-project-name
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The executable names that scons creates on compilation for editor and export templates now reflects the new project name.