Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace default Noto Sans font with Inter #716

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DeeJayLSP
Copy link
Contributor

Replaces the default font, currently Noto Sans, with Inter.

This follows some software that changed their default font to Inter, like Blender and GNOME.

@zaftnotameni
Copy link
Contributor

zaftnotameni commented Oct 15, 2024

could we have some screenshots at different window/font sizes and
also some screenshots of different character sets (non latin: arabic, japan/china, cyrillic)?

as we discussed in discord, I know you didn't change the font for all those cases, but doesn't hurt to test we didn't break something by accident

@zaftnotameni
Copy link
Contributor

adding cross reference: godotengine/godot-proposals#9012

@DeeJayLSP
Copy link
Contributor Author

DeeJayLSP commented Oct 15, 2024

Before PR:
image

After PR:
image

There is an issue with non-Latin/Greek/Cyrillic text, but this is an issue within Godot upstream (also happens in its latest builds, in which I also tested with and without this PR).

Overall, this should work the same as setting Main Font/Main Font Bold to Inter/Inter Bold in the editor settings.

Copy link
Contributor

@zaftnotameni zaftnotameni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR itself is fine, and thanks for taking the time and posting screenshots and everything (though a few more examples of different font sizes before/after for latin characters too would be nice as well)

I'm of 2 minds about this:

  • Seems to be a general trend of using this font instead of Noto as you pointed out, so probably overall a good thing.
  • Feels like a somewhat superfluous change, still unclear to me who this is helping other than looking very marginally better in some cases.

I'm approving because I don't see anything technically wrong with it, but would like to see a few thumbs up from people that would indicate this change is something people want for merging this.

@Spartan322
Copy link
Member

Spartan322 commented Oct 15, 2024

I would wonder about bringing the default font size down by one, as godot always has had a real estate issue.

@Majoramari
Copy link
Contributor

Is it possible to change the font for a specific language?

@DeeJayLSP
Copy link
Contributor Author

Is it possible to change the font for a specific language?

I don't think so, at least not without modifying the resource to include a remap for that language.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants