Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.3] Fix mono SDK references temporarily #785

Merged
merged 1 commit into from
Oct 23, 2024
Merged

[4.3] Fix mono SDK references temporarily #785

merged 1 commit into from
Oct 23, 2024

Conversation

Spartan322
Copy link
Member

@Spartan322 Spartan322 commented Oct 23, 2024 •
edited
Loading

Rebrand dotnet project metadata to reference Redot

Will need correction when https://www.nuget.org/packages/Redot.NET.Sdk is made.

@Spartan322 Spartan322 added bug rebranding issues and pr's related to engine rebranding topic:buildsystem topic:dotnet labels Oct 23, 2024
@Spartan322 Spartan322 force-pushed the 4.3-fix/temp-mono-sdk branch 2 times, most recently from b4abaa3 to ba41599 Compare October 23, 2024 11:38
@Spartan322
Fix mono SDK references temporarily
4f905b2 
Rebrand dotnet project metadata to reference Redot
decryptedchaos
decryptedchaos approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@decryptedchaos decryptedchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@trashguy trashguy self-requested a review October 23, 2024 16:38
trashguy
trashguy approved these changes Oct 23, 2024
View reviewed changes
Copy link

@trashguy trashguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I tested the regex changes local and it builds the SDK

@Spartan322 Spartan322 merged commit 7e93ced into Redot-Engine:4.3 Oct 23, 2024
18 checks passed
@Spartan322 Spartan322 deleted the 4.3-fix/temp-mono-sdk branch October 23, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@decryptedchaos decryptedchaos decryptedchaos approved these changes

@trashguy trashguy trashguy approved these changes

@SkogiB SkogiB SkogiB approved these changes

Assignees
No one assigned
Labels
bug rebranding issues and pr's related to engine rebranding topic:buildsystem topic:dotnet
Projects
Engine Overview
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Spartan322 @decryptedchaos @trashguy @SkogiB