Add some basic enanglement tests #26
Conversation
| binary_m.chars().nth(1).unwrap().to_digit(2).unwrap(), | ||
| input.first_bit as u32 | ||
| ); | ||
| // TODO: Positions are reversed, check if there is some sort of endianess happening. |
There was a problem hiding this comment.
Maybe related #25 ?
There was a problem hiding this comment.
You're right that the endianness issue is related to #25 - and the whole thing comes from the original iterators being defined to match how numpy handles outer (/tensor) products. Rewriting the internals may be an undertaking so I'm considering whether it's worthwhile.
|
Sorry - taking me a while to get to this. I'll consider whether an entanglement unit test could get a little fancier. Right now it seems to just be checking that the hadamard gate works as expected which is already covered by stuff like the CSWAP test. But something more interesting along these lines could be useful to have. |
|
No worries, i am just trying to understand how the software works and learning some quantum computing at the same time so probably some code i send will not be good enough to be included. I think we can close it, i can probably try to make something a bit different. Feel free to send suggestions on what you will like to see in a better entanglement test :) |
I was working with some basic entanglement so i created a few tests. Feel free to discord them if they are too basic or stuff already tested somewhere else.
There are also a few
TODOSs i added to the code that i can try to fix in the future.