Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: possible segfault in 64 bit deserialize_safe #663

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

Dr-Emann
Copy link
Member

The added test fails in ASAN without this change with an out-of-bounds read when art_insert_at computes a common prefix of 6 (all 48 bits), and tries to read the first non-matching byte of the key at

CRoaring/src/art/art.c

Lines 1172 to 1175 in 9526ecf

new_node = art_node_insert_leaf((art_inner_node_t *)new_node,
leaf->key[depth + common_prefix], leaf);
new_node = art_node_insert_leaf((art_inner_node_t *)new_node,
key[depth + common_prefix], new_leaf);

@lemire
Copy link
Member

lemire commented Sep 19, 2024

Excellent.

@lemire lemire merged commit 032450e into RoaringBitmap:master Sep 19, 2024
21 checks passed
@Dr-Emann Dr-Emann deleted the push-swtvlmrnkwwp branch September 19, 2024 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants