adding roaring64 to fuzzer as a step toward solving issue 662 #670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll merge eagerly. |
Dr-Emann
reviewed
Oct 1, 2024
Comment on lines
+81
to
+90
| int r; | ||
| r = bitmap32(data, size); | ||
| if (r) { | ||
| return r; | ||
| } | ||
| r = bitmap64(data, size); | ||
| if (r) { | ||
| return r; | ||
| } | ||
| return 0; |
There was a problem hiding this comment.
I've found that the fuzzer does a better job exploring the possibility space if you have it chose between operations rather than just running multiple operations. It can better find interesting inputs for each operation, rather than wasting time running what's interesting for one operation for other operations. I think the fuzzer would be more efficient if we do something like:
if (size == 0) { return 0; }
if (data[0] % 2 == 0) {
return bitmap32(data + 1, size - 1);
} else {
return bitmap64(data + 1, size - 1);
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do not, currently, ensure that
roaring64_bitmap_portable_deserialize_safeleaves the bitmap in a proper state after deserialization. This addition to the fuzzer might help.Related to #662