-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2 0 for real #137
2 0 for real #137
Conversation
@saulius, what are your thoughts on matching the CRoaring versioning exactly (bumping croaring-sys to |
@Dr-Emann I'd agree for the |
Yeah, absolutely it doesn't make sense to match on the croaring crate itself. |
Adding must_use is technically a breaking change, would like to get this in now
Also noticed some functions which should have |
Great work @Dr-Emann, thanks for shipping it! |
Add some tests which will fail until we get a 4.0.1 of CRoaring. Don't merge until we update again once CRoaring is fixed.
Also, include the matching CRoaring version in the readme and some clarification on versioning, this will hopefully help clarify somewhat the questions raised in #136. Link to the rendered added section: https://github.com/Dr-Emann/croaring-rs/blob/2_0_for_real/README.md#croaring-version
Fixes #136