Update to 4.1.2 #154
Update to 4.1.2 #154
Conversation
| @@ -25,7 +25,7 @@ roaring = "0.10" | |||
| criterion = { version = "0.5", features = ["html_reports"] } | |||
|
|
|||
| [dependencies] | |||
| ffi = { package = "croaring-sys", path = "../croaring-sys", version = "~4.1.1" } | |||
| ffi = { package = "croaring-sys", path = "../croaring-sys", version = "~4.1.2" } | |||
There was a problem hiding this comment.
I see CI failed because of this dependency bump. Perhaps we shouldn't increase versions in the PRs, what do you think? Basically we can merge any amount of changes to main branch and then do a release commit like this. Before release commit gets pushed to github you'd need to publish croaring-sys and then croaring crates of new versions. After release commit gets pushed you can do a Github release of a new version. That was the action sequence I always used. How does that sound?
There was a problem hiding this comment.
Hmm. I'm realizing with the changes from #149 to actually test croaring-rs against the real minimal versions, that test will always fail if we both update croaring-sys and croaring-rs to use the new functions at the same time: If we don't bump the versions, it'll still error because the new functions don't exist in the croaring-sys crate as published.
Not sure what the best way forward is: could always split into two PRs, croaring-sys only, then push a new version of it, and then a PR to use the new functions after the sys crate is published. That seems a bit of overhead though.
Dr-Emann
force-pushed
the
push-pulvozozkqvk
branch
from
51a43dd
to
7d70df2
Compare
No description provided.