-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support no_std #266
feat: support no_std #266
Conversation
Instead of having all these separate I noticed [dependencies]
bytemuck = { version = "1.7.3", optional = true }
byteorder = { version = "1.4.3", optional = true }
serde = { version = "1.0.139", optional = true }
[features]
default = ["std"]
serde = ["dep:serde", "std"]
simd = []
std = ["dep:bytemuck", "dep:byteorder"] So a build with no default features will have no dependencies besides the |
Since no one has responded to this PR for a long time, I wonder if there is any plan to continue support no_std? |
No commit has been made in 5 months, probably the maintainers are busy. |
ok, I'll take your suggestions, thanks! |
@Kerollmops Hello! Will |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jf2048 and @GZTimeWalker 👋
Sorry for the long response time. I was, indeed, swamped working on meilisearch/heed and meilisearch/Meilisearch.
Your changes look good to me overall! However, you'll probably encounter formatting issues in the CI. I advise you to do a small cargo +nightly fmt
before pushing to this PR again 😃
Thank you very much 🎉
note: all tests passed
I tested the latest version for all dependencies, all works fine and all tests passed, so I locked them to latest. note that this pr has already run |
Thank you very much @GZTimeWalker. I am in the process of bumping the MSRV and fixing the SIMD feature in #267. Would it be possible to rebase on the main once I merge it, please? After that, I will merge yours and #264 to create a new release. |
Sure. |
Can you rebase on main, please? 😃 |
Ok, wait a second |
Merged |
Thank you very much for this addition 🎉 |
This is only a early pr for support
no_std
.All tests are passed. Use
core
andalloc
instead ofstd
.There should be some better ways to disable serialization tests when
no_std
.For issue #265