-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve issues with no std #279
Conversation
LGTM; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for the changes 🍦
However, to be sure that we don't break the code once again would it be possible to duplicate this part of the CI and change the parameters to run the tests (or at least compile) in no-std, please?
Just add this part: - name: Test
uses: actions-rs/cargo@v1
with:
command: test
args: --no-default-features or - name: Test
uses: actions-rs/cargo@v1
with:
command: build
args: --no-default-features |
I would say let's try with the test one, but if it doesn't pass, we can only try to build it. |
Thanks, I'll try this now and see how it goes. |
It seems that all the checks passed as expected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much, folks 👌 I am merging this. I will do a release once #280 is merged too!
Should resolve #278 and resolve #273 and also satisfy the clippy lints via cfg flags.