Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve issues with no std #279

Merged
merged 2 commits into from
May 30, 2024
Merged

Conversation

kirk-baird
Copy link
Contributor

@kirk-baird kirk-baird commented May 28, 2024

Should resolve #278 and resolve #273 and also satisfy the clippy lints via cfg flags.

@GZTimeWalker
Copy link
Contributor

LGTM;

Copy link
Member

@Kerollmops Kerollmops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the changes 🍦

However, to be sure that we don't break the code once again would it be possible to duplicate this part of the CI and change the parameters to run the tests (or at least compile) in no-std, please?

@GZTimeWalker
Copy link
Contributor

Just add this part:

- name: Test
  uses: actions-rs/cargo@v1
  with:
    command: test
    args: --no-default-features

or

- name: Test
  uses: actions-rs/cargo@v1
  with:
    command: build
    args: --no-default-features

@Kerollmops
Copy link
Member

I would say let's try with the test one, but if it doesn't pass, we can only try to build it.

@kirk-baird
Copy link
Contributor Author

Thanks, I'll try this now and see how it goes.

@GZTimeWalker
Copy link
Contributor

It seems that all the checks passed as expected.

Copy link
Member

@Kerollmops Kerollmops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much, folks 👌 I am merging this. I will do a release once #280 is merged too!

@Kerollmops Kerollmops merged commit 576a7c0 into RoaringBitmap:main May 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The imports removed in 0.10.4 causes the inability to use no_std E0433 and E0412 for type Vec in 0.10.4
3 participants