Implement Clone on the bitmap::Iter type #289
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kerollmops
force-pushed
the
clone-iter-slice
branch
from
62038c7
to
abfabf4
Compare
Kerollmops
force-pushed
the
clone-iter-slice
branch
from
1b32c1e
to
d8f1829
Compare
Kerollmops
force-pushed
the
clone-iter-slice
branch
from
a361213
to
6bba84b
Compare
Dr-Emann
reviewed
Nov 1, 2024
|
|
||
| /// Detailed statistics on the composition of a bitmap. | ||
| #[derive(Clone, Copy, PartialEq, Debug)] | ||
| pub struct Statistics { |
There was a problem hiding this comment.
Probably worth a #[non_exhaustive], to be able to add fields backwards-compatibly.
| } | ||
| Store::Bitmap(bitmap) => { | ||
| cardinality += bitmap.len(); | ||
| n_values_bitset_containers += bitmap.len() as u32; |
There was a problem hiding this comment.
This could theoretically overflow n_values_bitset_containers if you have a full bitmap. Not sure if that's a problem or not.
If we ever implement run containers, that's much more likely, since it'd take much less memory to hold a totally full bitmap of all full run containers
| @@ -30,6 +30,10 @@ impl ArrayStore { | |||
| ArrayStore { vec: Vec::with_capacity(capacity) } | |||
| } | |||
|
|
|||
| pub fn capacity(&self) -> usize { | |||
There was a problem hiding this comment.
We'd at least need to document that this is the capacity of containers, not the capacity of values, or maybe have a different name?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.