Fix warnings when testing with nightly #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keep testing arbitrary implementations as pub(crate). This avoids warnings about undocumented public APIs
Kerollmops
requested changes
Oct 10, 2024
There was a problem hiding this comment.
Hey @Dr-Emann 👋
Thank you very much for this. Would you mind also modifying the "Unchanged files with check annotations" errors that you can see in the "Files changed" tab, please?
Have a nice one!
|
Thabk you very much! Merging 😇 BTW @Dr-Emann, I sent you an email with my @meilisearch.com email address. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep testing arbitrary implementations as pub(crate). This avoids warnings about undocumented public APIs.
Should fix CI issues found in #291, #292, #288