Full rebuild August 2026 II : bump ros2-distro-mutex to 0.20.0 and build number to 25 + Add RoboPlan packages - #38
Conversation
| dep_name: proxsuite | ||
| max_pin: 'x.x' | ||
| override_version: '0.7.2' | ||
| override_version: '0.7.3' |
There was a problem hiding this comment.
Note to self/other reviewers: in general we try to avoid doing this for abi compat version, but as this is an header only library isn ot a problem.
There was a problem hiding this comment.
I'd be fine with proxsuite 0.7.2 as well, though, if it's better
There was a problem hiding this comment.
I guess if you install ros2-proxsuite 0.7.2 , you end up with proxsuite 0.7.3 being installed, as ros2-proxsuite has a proxsuite >=0.7.2,<0.8.0a0 dep on proxsuite, see https://prefix.dev/channels/robostack-rolling/packages/ros2-proxsuite (this derive from max_pin: 'x.x') used here.
dfedb4b to
091b462
Compare
41734b9 to
6d9f7f3
Compare
|
It does appear the macos and Windows jobs blew past the 6 hour timeout 🤣 |
The cache is there and active, so just restarting should work fine. |
Even without removing packages and letting the job run to completion? (I reverted the change, but will need help restarting the cancelled jobs since I don't have permissions) |
Yes, the cache is saved also on jobs with timeout. |
Ok, apparently not, but it will be again soon: #40 . |
|
I just rebased on |
|
I thin the macos arm run failed due to a race with the recipes checker, probably just needs a re-run? thanks! |
|
I see that the build timed out, but the cache was uploaded properly this time. I think we just need to close and reopen the PR a few times and it should eventually pass, assuming there are no actual build errors. From my previous experience, a full Windows rebuild take around 18 hours |
|
So it appears there was an issue on Windows. The cached build for I've modified the workflow YAML temporarily to remove the bad cache since there seems to be precedent for that. But maybe we can kick off this rerun the 2nd macos job completes so we don't accidentally damage that one 🙃 |
|
ok the macos jobs have all passed, this should be good to approve the workflow and get the windows build passing now -- thanks, all! |
|
@traversaro this seems ready to go! |
Thanks a lot! I would just de-vendor mujoco as done in the other distros to avoid confusion, let me do that change. |
Actually mujoco was already devendored, I just added an option to ensure it was never accidentally vendored again. |
Adds all the roboplan / roboplan-ros packages, except for
roboplan_ros_frankawhich requiresmujoco_ros2_control.Also does a full rebuild to update Pinocchio and Coal, bumping the build number to 25.
Closes #28