-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update thumb message layout #5872
base: develop
Are you sure you want to change the base?
Conversation
f95c6d8
to
d7c9f29
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a typo.
Create a channel on our workspace, send those messages and add to PR description.
It's going to make review and QA easier.
@@ -43,6 +43,11 @@ const styles = StyleSheet.create({ | |||
alignItems: 'center', | |||
marginBottom: 8 | |||
}, | |||
titleAndDesciptionContainer: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
titleAndDesciptionContainer: { | |
titleAndDescriptionContainer: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Images on before and after look the same.
d68edbb
to
687a0de
Compare
687a0de
to
142a86a
Compare
Proposed changes
Reduce the thumb image size and adjust the reply component layout to improve its distribution and optimize the space occupied by the message.
Issue(s)
https://rocketchat.atlassian.net/browse/NATIVE-622
How to test or reproduce
If you have one room with a message that have a thumb URL you can open this room, or you can mock this messages on List component:
Screenshots
IOS
Before - After
Android
Before - After
Types of changes
Checklist
Further comments